Fix name of jaeger_remote polling interval property #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
Closed
5 tasks
|
Thanks, @drewhammond ! |
theletterf
approved these changes
Aug 26, 2024
|
After discussion in open-telemetry/opentelemetry-specification#4195, I think it makes sense to revert this doc change and fix the java implementation instead. |
drewhammond
added a commit
to drewhammond/opentelemetry.io
that referenced
this pull request
Aug 26, 2024
…emetry#5100)" This reverts commit 22fca80.
This was referenced Aug 26, 2024
michael2893
pushed a commit
to michael2893/opentelemetry.io
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply corrects the name of the polling interval property used by the
jaeger_remoteandparentbased_jaeger_remotesamplers.Ref: https://github.com/open-telemetry/opentelemetry-java/blob/c90175f1ae7d15fef6bac8eb6c95492c981daa61/sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSamplerProvider.java#L22