Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDPDataStore and VDPRegViewer code repetition #159

Open
pvmm opened this issue Feb 5, 2023 · 0 comments
Open

VDPDataStore and VDPRegViewer code repetition #159

pvmm opened this issue Feb 5, 2023 · 0 comments

Comments

@pvmm
Copy link
Contributor

pvmm commented Feb 5, 2023

	int total = TOTAL_SIZE - !registerLatchAvailable - !paletteLatchAvailable - !dataLatchAvailable;
	new SimpleHexRequest(req, total, regs, *this);

This code block is largely repeated between VDPDataStore and VDPRegViewer. Can we (in a separate commit) reduce this duplication? Ideally store/query this information only in a single location.

Originally posted by @m9710797 in #157 (comment)

@pvmm pvmm changed the title VDPDAtaStore and VDPRegViewer code repetition VDPDataStore and VDPRegViewer code repetition Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant