Skip to content

Commit a285380

Browse files
committed
Fix #83: Allow personname related elements
In regards to personname: * Allow givenname, othername, honorifc, and linage * Restore content model of personname to not mix firstname with givenname
1 parent 8ab378f commit a285380

File tree

4 files changed

+58
-8
lines changed

4 files changed

+58
-8
lines changed

geekodoc/rng/2_5.2/geekodoc-v2.rnc

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ include "db52itsxi.rnc"
319319
db.guisubmenu = notAllowed
320320
db.hardware = notAllowed
321321
# db.holder = notAllowed
322-
db.honorific = notAllowed
322+
# db.honorific = notAllowed
323323
# db.imagedata = notAllowed
324324
# db.imageobject = notAllowed
325325
db.imageobjectco = notAllowed
@@ -349,7 +349,7 @@ include "db52itsxi.rnc"
349349
db.label = notAllowed
350350
# db.legalnotice = notAllowed
351351
db.lhs = notAllowed
352-
db.lineage = notAllowed
352+
# db.lineage = notAllowed
353353
db.lineannotation = notAllowed
354354
# db.link = notAllowed
355355
# db.listitem = notAllowed
@@ -1442,17 +1442,24 @@ include "db52itsxi.rnc"
14421442
}
14431443

14441444
# personname
1445+
# Issue #83: Allow givenname, lineage, and honorific
14451446
div {
14461447
# Removed text
14471448
db.personname =
14481449
## The personal name of an individual
14491450
element personname {
14501451
db.personname.attlist,
1451-
(db.honorific
1452-
| db.firstname
1453-
| db.surname
1454-
| db.lineage
1455-
| db.othername)+
1452+
( (db.honorific
1453+
| db.firstname
1454+
| db.surname
1455+
| db.lineage
1456+
| db.othername)+
1457+
| (db.honorific
1458+
| db.givenname
1459+
| db.surname
1460+
| db.lineage
1461+
| db.othername)+
1462+
)
14561463
}
14571464
db.person.author.contentmodel =
14581465
db.personname,
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<?xml-model href="geekodoc-v2-flat.rnc" type="application/relax-ng-compact-syntax"?>
3+
<article xmlns="http://docbook.org/ns/docbook" version="5.2">
4+
<title>Bad names</title>
5+
<info>
6+
<author>
7+
<personname>
8+
<firstname>Tux</firstname>
9+
<givenname>Tix</givenname>
10+
<surname>Penguin</surname>
11+
</personname>
12+
</author>
13+
<author>
14+
<personname>
15+
<givenname>Geeko</givenname>
16+
<givenname>Gecko</givenname>
17+
<surname>Chamaeleon</surname>
18+
</personname>
19+
</author>
20+
</info>
21+
<para/>
22+
</article>

tests/v2/good/geekodoc-v2-flat.rnc

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<?xml-model href="geekodoc-v2-flat.rnc" type="application/relax-ng-compact-syntax"?>
3+
<article xmlns="http://docbook.org/ns/docbook" version="5.2">
4+
<title>Good names</title>
5+
<info>
6+
<author>
7+
<personname>
8+
<firstname>Tux</firstname>
9+
<surname>Penguin</surname>
10+
</personname>
11+
</author>
12+
<author>
13+
<personname>
14+
<givenname>Geeko</givenname>
15+
<givenname>Gecko</givenname>
16+
<surname>Chamaeleon</surname>
17+
<lineage>Jr.</lineage>
18+
</personname>
19+
</author>
20+
</info>
21+
<para/>
22+
</article>

0 commit comments

Comments
 (0)