Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using validation results in the normalisation process #52

Open
rhiaro opened this issue Jul 14, 2020 · 5 comments
Open

Using validation results in the normalisation process #52

rhiaro opened this issue Jul 14, 2020 · 5 comments

Comments

@rhiaro
Copy link
Collaborator

rhiaro commented Jul 14, 2020

A NormalisedEvent:

  • should not contain any fields with empty or null values.
  • should have all fields that are not in the OA modelling spec or prefixed with beta: moved to an invalidAttributes object.

The best way to detect both of these is from the results of validating the object. We either need to:

  • be able to guarantee the validation is run before the normalisation pipes, so we can access the results from the database, or
  • run the validator from inside the pipes; which might be a significant performance hit.
@rhiaro
Copy link
Collaborator Author

rhiaro commented Jul 14, 2020

Normalisations

@nickevansuk
Copy link
Contributor

Just a note that beta: attributes sometimes give useful information. A decision was made in modelling spec development to encourage the use of beta: over further iterations of the modelling spec, so hence many useful properties remain in beta, and beta is now quite extensive as a result.

beta properties can be readily validated against https://openactive.io/ns-beta/beta.jsonld if that's helpful

@nickevansuk
Copy link
Contributor

To make this relevant to the present COVID-19 situation, most of the properties that describe virtual events are in fact in beta, for the same reason

@rhiaro
Copy link
Collaborator Author

rhiaro commented Jul 14, 2020

Thanks @nickevansuk. Current behaviour is to pass beta properties through and republish them unchanged, so nothing should be lost there.

@rhiaro
Copy link
Collaborator Author

rhiaro commented Jul 29, 2020

Data cleaning pipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants