fix resume --last prompt handling and reinstate session-id conflict check #7357
+506
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed:
Changes
--lastflag to accept optional prompt value (e.g.--last <PROMPT>)last_prompt()helper methodconflicts_withbetween--lastand explicit session idProblems
1. Interactive
codex resume --lastdidn't accept prompt values (#6717)Problem: The interactive
codex resume --lastcommand used a boolean flag that couldn't accept a prompt value. Users couldn't provide a prompt directly after--last.Before:
After:
2.
codex exec resumesilently ignored session_id when used with--last(#6719 discussion)Problem: When both a session ID and
--lastwere provided, the code silently ignored the session ID and used--last, potentially resuming the wrong session. This was unsafe for scripts and users.Before:
After:
3. Invalid session IDs silently created new conversations
Problem: When an invalid or nonexistent session ID was provided,
codex exec resumesilently created a new conversation instead of erroring, causing confusion.Before:
After:
Testing
Added tests for:
--lastand session ID--last <PROMPT>All existing tests pass, and the behavior now matches the interactive
codex resumecommand which already had proper error handling.