Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework confirm registration endpoint to support upcoming integrations #6954

Open
euanmillar opened this issue May 8, 2024 · 0 comments
Open
Assignees
Milestone

Comments

@euanmillar
Copy link
Collaborator

euanmillar commented May 8, 2024

MOSIP - Open Source Identity Platform

🔁 Current state

Currently the country config event-registration handler calls workflow -package to add the necessary identifiers for a child (a national id / NIN for example). We can implement MOSIP integration here, waiting for the MOSIP to respond and then calling the CONFIRM_REGISTRATION_URL.

When a person dies, core has hardcoded ways of passing information to MOSIP.

Problems with the approach

  • Security: instead of calling workflow directly via CONFIRM_REGISTRATION_URL, it needs to go via gateway-service to allow one entrypoint only to core
  • Error handling: we need a new rejectRegistration endpoint if MOSIP cannot register a NID
  • Country-config upgrading ease: country-config needs to have less code to make upgrades easier
  • Core separation of concerns: core now has code and references hardcoded to MOSIP - we want core to be integration-agnostic

🚀 Proposal

High-level diagram of the proposed flow

In short; the country config event-registration handler (which calls reject or confirm) should be able to be commented out and 'hijacked' by an integration like MOSIP.

  • Allow an HTTP request with a correct token to confirm or reject the registration via gateway
  • Import event-registration -route from MOSIP repository. This route calls the OpenCRVS-side MOSIP-mediator
@github-project-automation github-project-automation bot moved this to Backlog in OpenCRVS Core May 8, 2024
@euanmillar euanmillar added this to the v1.7.0 milestone May 8, 2024
@euanmillar euanmillar changed the title Re-design / re-build of scalable OpenCRVS / MOSIP basic Birth & Death integration Re-design / re-build of official (not a P.O.C.) OpenCRVS / MOSIP basic Birth & Death integration May 8, 2024
@naftis naftis moved this from Backlog to In Development in OpenCRVS Core Aug 27, 2024
@naftis naftis changed the title Re-design / re-build of official (not a P.O.C.) OpenCRVS / MOSIP basic Birth & Death integration Build a MOSIP birth & death integration v1 Oct 23, 2024
@naftis naftis added the Tech label Oct 23, 2024
@naftis naftis changed the title Build a MOSIP birth & death integration v1 Build a MOSIP birth & death integration v2 Oct 23, 2024
@naftis naftis added the Bevolv label Oct 28, 2024
@naftis naftis changed the title Build a MOSIP birth & death integration v2 Rework confirm registration endpoint to support upcoming integrations Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Development
Development

No branches or pull requests

2 participants