Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple blank spaces are in the user address if some of the fields are empty #5192

Closed
ShohelaTasin opened this issue Apr 28, 2023 · 3 comments · Fixed by #7630
Closed

Multiple blank spaces are in the user address if some of the fields are empty #5192

ShohelaTasin opened this issue Apr 28, 2023 · 3 comments · Fixed by #7630
Assignees
@tumbledwyer
Labels
Bug UI/UX
Milestone
v1.7.0

Comments

@ShohelaTasin
Copy link

ShohelaTasin commented Apr 28, 2023 •
edited by jpye-finch
Loading

Improvement :
Description :
After entering data into address fields while creating a new records,
we face a trivial view from review page!

Actual Result :

Data seems in a noisy manner!
No clue for what data indicate what specific field!
And seems blank spaces while entering non adjacent/non immediate fields!

Expected Result :
No additional line gaps should exist

Screen Recording : https://www.loom.com/share/278910ad33334a039581e828b6053675

Screenshot (40).png
@anny320 anny320 changed the title UI Improvement needed : All address fields should be in a sequential manner ! UI Improvement needed : Multiple blank spaces are in the user address if some of the fields are empty: All address fields should be in a sequential manner ! May 3, 2023
@jpye-finch
Copy link
Collaborator

We should remove the blank lines if no data is entered.

So the above example would read:

El Salvador
Mohakhali
District required for registration
United
Land

@SyedaAfrida SyedaAfrida changed the title UI Improvement needed : Multiple blank spaces are in the user address if some of the fields are empty: All address fields should be in a sequential manner ! UI Improvement needed : Multiple blank spaces are in the user address if some of the fields are empty May 3, 2023
@jpye-finch jpye-finch added the bug label Oct 18, 2023
@jpye-finch jpye-finch added Bug and removed bug labels Nov 22, 2023
@jpye-finch jpye-finch moved this to Backlog in OpenCRVS Core Nov 22, 2023
@jpye-finch jpye-finch moved this from Backlog to Ready to build in OpenCRVS Core Dec 11, 2023
@SyedaAfrida SyedaAfrida moved this from Ready to build to Backlog in OpenCRVS Core Dec 12, 2023
@jpye-finch jpye-finch moved this from Backlog to Ready to build in OpenCRVS Core Mar 14, 2024
@jpye-finch jpye-finch changed the title UI Improvement needed : Multiple blank spaces are in the user address if some of the fields are empty Multiple blank spaces are in the user address if some of the fields are empty Mar 29, 2024
@euanmillar
Copy link
Collaborator

@eduffus @SyedaAfrida this seems trivial and needs a re-test and re-prioritisation

@SyedaAfrida SyedaAfrida added this to the v1.5.0 milestone Jun 5, 2024
@euanmillar euanmillar removed this from the v1.5.0 milestone Jun 7, 2024
@jpye-finch
Copy link
Collaborator

@SyedaAfrida @euanmillar

Flagging this ticket for reprioritisation. Would be good to fix.

Image

@SyedaAfrida SyedaAfrida added this to the v1.7.0 milestone Sep 10, 2024
@Nil20 Nil20 assigned Nil20 and unassigned Nil20 Sep 17, 2024
@tumbledwyer tumbledwyer self-assigned this Sep 17, 2024
@tumbledwyer tumbledwyer moved this from Ready to build to In Development in OpenCRVS Core Sep 17, 2024
@tumbledwyer tumbledwyer mentioned this issue Sep 18, 2024
Merged
@tumbledwyer tumbledwyer moved this from In Development to In Code Review in OpenCRVS Core Sep 18, 2024
@tumbledwyer tumbledwyer moved this from In Code Review to Pending for release cherry-pick in OpenCRVS Core Sep 25, 2024
@tumbledwyer tumbledwyer moved this from Pending for release cherry-pick to In Code Review in OpenCRVS Core Sep 26, 2024
@github-project-automation github-project-automation bot moved this from In Code Review to Completed in OpenCRVS Core Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tumbledwyer tumbledwyer

Labels
Bug UI/UX
Projects
OpenCRVS Core
Archived in project
Milestone
v1.7.0
Development

Successfully merging a pull request may close this issue.

fix(v1.7.0): Improvement to only show items with values in review opencrvs/opencrvs-core
6 participants
@euanmillar @tumbledwyer @Nil20 @ShohelaTasin @jpye-finch @SyedaAfrida