Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(User roles) fix: Send for review action button display logic #7973

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

tumbledwyer
Copy link
Collaborator

Changed to satisfy the requirement:

GIVEN i don't have the record.declaration-submit-incomplete but the record.declaration-submit-for-review
WHEN on the review page and the declaration is incomplete
THEN show the incomplete state with the button "Send for review" disabled
#7421

GIVEN i don't have the record.declaration-submit-incomplete but the record.declaration-submit-for-review
WHEN on the review page and the declaration is incomplete
THEN show the incomplete state with the button "Send for review" disabled
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Zangetsu101
Copy link
Collaborator

@tumbledwyer is the PR up to date with the base branch? The failing client test might be because of that

@Zangetsu101
Copy link
Collaborator

@tumbledwyer is the PR up to date with the base branch? The failing client test might be because of that

The issue was in the base branch

I'll merge this in now

@Zangetsu101 Zangetsu101 merged commit a5ca6a1 into configurable-roles Nov 14, 2024
57 of 60 checks passed
@Zangetsu101 Zangetsu101 deleted the action-component-fix branch November 14, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants