Skip to content

Commit 5401ebd

Browse files
committed
curvefs/client:the implementation of readdirplus is problematic
The current implementation of this interface is problematic, resulting in inconsistent metadata signed-off-by: hzwuhongsong hzwuhongsong@corp.netease.com
1 parent e03ce33 commit 5401ebd

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

curvefs/src/client/main.cpp

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,13 @@ static const struct fuse_lowlevel_ops curve_ll_oper = {
4747
release : FuseOpRelease,
4848
fsync : FuseOpFsync,
4949
opendir : FuseOpOpenDir,
50-
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
51-
readdir : 0,
52-
#else
50+
// TODO(wuhongsong): readdirplus is problematic,
51+
// resulting in inconsistent metadata
52+
// #if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
53+
// readdir : 0,
54+
// #else
5355
readdir : FuseOpReadDir,
54-
#endif
56+
// #endif
5557
releasedir : FuseOpReleaseDir,
5658
fsyncdir : 0,
5759
statfs : FuseOpStatFs,
@@ -75,9 +77,11 @@ static const struct fuse_lowlevel_ops curve_ll_oper = {
7577
flock : 0,
7678
fallocate : 0,
7779
#endif
78-
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
79-
readdirplus : FuseOpReadDirPlus,
80-
#endif
80+
// TODO(wuhongsong): The current implementation is problematic,
81+
// resulting in inconsistent metadata
82+
// #if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 0)
83+
readdirplus : 0,
84+
// #endif
8185
#if FUSE_VERSION >= FUSE_MAKE_VERSION(3, 4)
8286
copy_file_range : 0,
8387
#endif

0 commit comments

Comments
 (0)