Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve tool]: implement clean-recyle command #2032

Closed
cw123 opened this issue Nov 4, 2022 · 8 comments
Closed

[curve tool]: implement clean-recyle command #2032

cw123 opened this issue Nov 4, 2022 · 8 comments
Assignees
Labels
good first issue Good for newcomers tools Tool improvements

Comments

@cw123
Copy link
Contributor

cw123 commented Nov 4, 2022

Describe the feature you'd like:

we'd like to support clean-recycle command in curve tool

clean-recycle is one of the commands to delete all volume under recycle of curveBS.

The curveBS has a recycle, every volume deleted will mv to the recycle. The clean-recycle command will delete all the volume under the recycle.

The path of the recycle in the curveBS is /RecycleBin.

  • The implementation of the old tool is here:

https://github.com/opencurve/curve/blob/master/src/tools/namespace_tool_core.cpp#L134

  • The old command:
clean-recycle : clean the RecycleBin

$ curve_ops_tool clean-recycle --example
Example:
curve_ops_tool clean-recycle -mdsAddr=127.0.0.1:6666 [-fileName=/cinder]
If -fileName is specified, delete the files in recyclebin that the original directory is fileName

  • The new command we want:
curve bs clean-recycle

If command sucess, print success.
If command failed, print failed, and the fail reason.

Teachability, Documentation, Adoption, Migration Strategy:

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

@zhanghuidinah
Copy link
Member

/assign @Joey777210

@ilixiaocui
Copy link
Contributor

Please note that the code submission deadline for this developer activity is December 3rd :)
@Joey777210

@wuhongsong
Copy link
Contributor

you are welcome to continue the work if you are free @Joey777210

@ilixiaocui
Copy link
Contributor

ilixiaocui commented Jan 5, 2023

cc @Joey777210 Since you haven't responded for a long time, this issue is reopened to others who is interested.

@lng2020
Copy link
Contributor

lng2020 commented Apr 6, 2023

I would like to contribute to this issue, please assign it to me. @ilixiaocui

@ilixiaocui
Copy link
Contributor

I would like to contribute to this issue, please assign it to me. @ilixiaocui

Welcome!

@zhanghuidinah
Copy link
Member

@lng2020
Copy link
Contributor

lng2020 commented Apr 14, 2023

complete a pr for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tools Tool improvements
Projects
None yet
Development

No branches or pull requests

6 participants