Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve/toos-v2]: add update-throttle #2358

Closed
Cyber-SiKu opened this issue Mar 30, 2023 · 1 comment
Closed

[curve/toos-v2]: add update-throttle #2358

Cyber-SiKu opened this issue Mar 30, 2023 · 1 comment
Labels
enhancement improve feature good first issue Good for newcomers

Comments

@Cyber-SiKu
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support bs set throttle command in curve tool

  • The implementation of the old tool is here:
    int NameSpaceToolCore::UpdateFileThrottle(const std::string& fileName,
    const std::string& throttleType,
    const uint64_t limit,
    const int64_t burst,
    const int64_t burstLength) {
    curve::mds::ThrottleType type;
    if (!curve::mds::ThrottleType_Parse(throttleType, &type)) {
    std::cout
    << "Parse throttle type '" << throttleType
    << "' failed, only support "
    "IOPS_TOTAL|IOPS_READ|IOPS_WRITE|BPS_TOTAL|BPS_READ|BPS_WRITE"
    << std::endl;
    return -1;
    }
    curve::mds::ThrottleParams params;
    params.set_limit(limit);
    params.set_type(type);
    if (burst >= 0) {
    if (burst < limit) {
    std::cout << "burst should greater equal to limit" << std::endl;
    return -1;
    }
    params.set_burst(burst);
    params.set_burstlength(burstLength > 0 ? burstLength : 1);
    }
  • The old command input and out put:
curve_ops_tool update-throttle

-------
output:

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

Describe the solution you'd like (描述你期望的解决方法)

Add subcommand clinet to curve bs list.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@zhanghuidinah
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants