Skip to content

Conversation

@jiridanek
Copy link
Member

@jiridanek jiridanek commented Nov 28, 2025

https://issues.redhat.com/browse/RHAIENG-2174

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated Docker build configurations to optimize package installation performance and offline capability.

✏️ Tip: You can customize this high-level summary in your review settings.

…vice" due to AIPCC base disabling `uv` cache
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2025

Walkthrough

Two Dockerfile configurations for Python 3.12 environments on UBI9 are updated to modify UV package manager caching behavior. Changes add UV_NO_CACHE=false environment variables and --offline flags across multiple build stages in both wheel caching and final package installation steps.

Changes

Cohort / File(s) Summary
UV caching configuration updates
codeserver/ubi9-python-3.12/Dockerfile.cpu, jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu
Added UV_NO_CACHE=false environment variable to uv pip install commands in wheel caching and CPU build stages. Introduced --offline flag for final package installation step while retaining --requirements and --cache-dir semantics. Architecture-specific (PPC64le/s390x) wheels installation updated with new caching directives. Subsequent git-based debugpy installation preserved in both files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Both files undergo consistent, homogeneous pattern changes (same UV configuration modifications applied across multiple stages)
  • Changes are configuration-level environmental variable and flag additions without logic modifications
  • Straightforward verification of caching behavior and offline mode applicability across build stages

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description references the issue but lacks detail about the actual changes and how they fix the problem; testing section only links to CI without explanation, and merge criteria checklist items remain unchecked. Add a detailed 'Description' section explaining what was changed and why (e.g., how UV_NO_CACHE=false and --offline fix the disk space issue). Provide context about the testing results linked, and check the merge criteria boxes if completed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing a build failure by adjusting uv cache settings in Dockerfiles for codeserver and trustyai.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce64808 and eb48d22.

📒 Files selected for processing (2)
  • codeserver/ubi9-python-3.12/Dockerfile.cpu (3 hunks)
  • jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Red Hat Konflux / odh-workbench-codeserver-datascience-cpu-py312-ubi9-on-pull-request
  • GitHub Check: Red Hat Konflux / odh-workbench-jupyter-trustyai-cpu-py312-ubi9-on-pull-request
  • GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/amd64, false) / build
  • GitHub Check: build (codeserver-ubi9-python-3.12, 3.12, linux/arm64, false) / build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Nov 28, 2025
@openshift-ci openshift-ci bot added size/s and removed size/s labels Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek changed the title RHAIENG-2174: build(trustyai): fix build failure "no space left on device" due to AIPCC base disabling uv cache RHAIENG-2174: build(codeserver,trustyai): fix build failure "no space left on device" due to AIPCC base disabling uv cache Nov 28, 2025
@openshift-ci openshift-ci bot added size/s and removed size/s labels Nov 28, 2025
@jiridanek jiridanek marked this pull request as ready for review November 28, 2025 18:09
@openshift-ci openshift-ci bot requested review from atheo89 and daniellutz November 28, 2025 18:09
@openshift-ci openshift-ci bot added size/s and removed size/s labels Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

@jiridanek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-jupyter-tai-ubi9-python-3-12-pr-image-mirror eb48d22 link true /test notebook-jupyter-tai-ubi9-python-3-12-pr-image-mirror
ci/prow/codeserver-ubi9-python-3-12-pr-image-mirror eb48d22 link true /test codeserver-ubi9-python-3-12-pr-image-mirror
ci/prow/images eb48d22 link true /test images
ci/prow/notebooks-py312-ubi9-e2e-tests eb48d22 link true /test notebooks-py312-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit 06394bd into opendatahub-io:main Nov 29, 2025
13 of 23 checks passed
@jiridanek jiridanek deleted the jd_cleanup_tmp branch November 29, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants