Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error adding ALLOWED_CHANGE_REF_TYPES as env variable #1252

Open
aoteropas opened this issue Nov 30, 2023 · 2 comments · May be fixed by #1253
Open

Error adding ALLOWED_CHANGE_REF_TYPES as env variable #1252

aoteropas opened this issue Nov 30, 2023 · 2 comments · May be fixed by #1253

Comments

@aoteropas
Copy link

https://github.com/opendevstack/ods-core/blob/0e02f3466cdd6f6e80a2c3a7d45509ff72f0ca97/jenkins/webhook-proxy/main.go#L207C18-L207C18

When:

  • Create Env Variable for Change Ref type that includes Branch and Tag

Expected result:

  • Webhook instance catches Tag pushed to the repo as a trigger event

Actual result:

  • Webhook instance does not load the env Variable and always say it is empty

Analysis:
The if clause is not checking the variable that retrieves en env information, is checking the empty array that will contain it after spliting (done inside the if)
@michaelsauter
Copy link
Member

Ouch! Want to contribute a fix?

@BraisVQ BraisVQ linked a pull request Dec 4, 2023 that will close this issue
Open
@metmajer
Copy link
Member

metmajer commented Dec 5, 2023

Thanks for the fix @aoteropas. @braisvq1996 @jafarre-bi please include it in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix allowed change ref types environment read aoteropas/ods-core
3 participants
@michaelsauter @metmajer @aoteropas