Skip to content

Improve support_tool_logs.log #1940

@tiagolobocastro

Description

@tiagolobocastro

Is your feature request related to a problem? Please describe.
The support tool logs all (or some) operations to a log file.
Sadly it doesn't include the version of the plugin, nor the version of the installed helm package (though note this last one can be figured out by manual inspection of the K8s resources).

Describe the solution you'd like

  1. Log useful information at the top, such as version of the plugin and helm package
  2. Prettify expected "errors" such as loki not being enabled - shouldn't be treated as a hard error
  • Failed to create loki client (Forward { source: ServiceNotFound { selector: "app=loki", namespace: NameSpace(Some("mayastor")) } }). Continuing...
  • Could not fetch rebuild history for d20e5c9d-c915-4760-9cec-68db712e2d28, error: RestJsonError(Response(Expected(ResponseContent { status: 412, body: RestJsonError { details: "", message: "volume target not available", kind: FailedPrecondition } })))
  1. Show user enabled helm values
  2. Show basic topology information in user-friendly tabled output (again this just makes a quick look easy to do without any tooling)

Describe alternatives you've considered
Specifically for the version of the plugin, there's no alternative, we have to dump it.
For the human friendly tables, we can always load the dump in the simulator, but this requires having to run it, which may not always be possible from a macbook for example - though we could build new tools (with no simulation) that could format the data into human friendly data.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/improvementCategorizes issue or PR as related to improving upon a current feature

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions