fix: update pb files after protobuf was upgraded #38
Conversation
Signed-off-by: mchtech <michu_an@126.com>
| @@ -18,6 +18,7 @@ ADD ./requirements.txt ./ | |||
| RUN pip install -r ./requirements.txt | |||
|
|
|||
| ADD ./ ./ | |||
| RUN python3 /usr/local/lib/python3.11/site-packages/grpc_tools/protoc.py --proto_path=protos/ protos/csi.proto --grpc_python_out=csi/ --python_out=csi/ | |||
There was a problem hiding this comment.
I think it should not be there
When we change pb files we have to do this and push changes
(We need some CI Tests for checking of that)
also python version is hard-coded
There was a problem hiding this comment.
You mean we should generate the pb file outside, and COPY it inside?
There was a problem hiding this comment.
Yes,
Also it is pointing to site-packages directly, it's better to use python -m instead
I think I will refactor Dockerfile to use Docker multi stage more efficiently
There was a problem hiding this comment.
Or we have to separate the stage for the generation
There was a problem hiding this comment.
Yes, we also use python -m on mayastor, but it's only for testing there, since the running code is in rust
There was a problem hiding this comment.
Yeah, but here it is not for test, and it is used for production Dockerfile
fix: #37
ff598bf upgraded
protobuf, so pb files should be regenerated.