Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

fix: iframe styling #355

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: iframe styling #355

merged 2 commits into from
Oct 30, 2023

Conversation

KristinAoki
Copy link
Contributor

JIRA Tickets: TNL-11148, TNL-11147

This PR aligns the component title and action buttons. This PR also fixes the padding around iframe and the iframes background color.

Before
Screenshot 2023-10-30 at 10 03 32 AM

After
Screenshot 2023-10-30 at 10 02 47 AM

@KristinAoki KristinAoki added the Content Libraries This PR is related to V2 content Libraries work label Oct 30, 2023
@KristinAoki KristinAoki requested a review from a team as a code owner October 30, 2023 14:03
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c75f877) 52.10% compared to head (5c0ee65) 52.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   52.10%   52.10%           
=======================================
  Files          75       75           
  Lines        1969     1969           
  Branches      355      355           
=======================================
  Hits         1026     1026           
  Misses        910      910           
  Partials       33       33           
Files Coverage Δ
...authoring/edit-block/LibraryBlock/LibraryBlock.jsx 58.53% <ø> (ø)
.../library-authoring/edit-block/LibraryBlock/wrap.js 18.44% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the screenshots.

@KristinAoki KristinAoki merged commit 0c1f4c0 into master Oct 30, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-iframe-styling branch October 30, 2023 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content Libraries This PR is related to V2 content Libraries work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants