Skip to content
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Fix tinymce editor problems #389

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

jesperhodge
Copy link
Contributor

@jesperhodge jesperhodge commented Dec 12, 2023

Internal issue: https://2u-internal.atlassian.net/servicedesk/customer/portal/9/CR-6328?created=true

Reverted frontend-lib-content-components library updates because:

scroll was not working on editors
potential problems with editor content loading

@jesperhodge jesperhodge requested a review from a team as a code owner December 12, 2023 23:33
Copy link

@bszabo bszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d99fa54) 52.41% compared to head (e35af9a) 52.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files          75       75           
  Lines        1986     1986           
  Branches      359      359           
=======================================
  Hits         1041     1041           
  Misses        912      912           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge jesperhodge merged commit 0fc84f1 into master Dec 12, 2023
@jesperhodge jesperhodge deleted the fix--tinymce-editor-problems-2 branch December 12, 2023 23:38
@bszabo
Copy link

bszabo commented Dec 14, 2023

The TNL team is actively working today on fixing FLCC to eliminate the vertical scrollbars problems seen in this PR. Once that's done, it will be possible to repoint library authoring to the most recent FLCC version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants