Skip to content

Commit 2d7a3d3

Browse files
UsamaSadiqUsamaSadiq
authored
fix: remove pylint constraint (#36169)
1 parent 3847cec commit 2d7a3d3

File tree

14 files changed

+98
-99
lines changed

14 files changed

+98
-99
lines changed

‎openedx/core/djangoapps/content_staging/tests/test_clipboard.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# pylint: skip-file
12
"""
23
Tests for the clipboard functionality
34
"""

‎pylint_django_settings.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from pylint_django.checkers import ForeignKeyStringsChecker
2-
from pylint_plugin_utils import get_checker
1+
import os
2+
import sys
33

44

55
class ArgumentCompatibilityError(Exception):
@@ -47,6 +47,4 @@ def load_configuration(linter):
4747
"""
4848
Configures the Django settings module based on the command-line arguments passed to pylint.
4949
"""
50-
name_checker = get_checker(linter, ForeignKeyStringsChecker)
51-
arguments = linter.cmdline_parser.parse_args()[1]
52-
name_checker.config.django_settings_module = _get_django_settings_module(arguments)
50+
os.environ.setdefault("DJANGO_SETTINGS_MODULE", _get_django_settings_module(sys.argv[1:]))

‎pylintrc

Lines changed: 34 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,18 @@
6464
# SERIOUSLY.
6565
#
6666
# ------------------------------
67-
# Generated by edx-lint version: 5.3.7
67+
# Generated by edx-lint version: 5.4.1
6868
# ------------------------------
6969
[MASTER]
7070
ignore = ,.git,.tox,migrations,node_modules,.pycharm_helpers
7171
persistent = yes
7272
load-plugins = edx_lint.pylint,pylint_django_settings,pylint_django,pylint_celery,pylint_pytest
7373

7474
[MESSAGES CONTROL]
75-
enable =
75+
enable =
7676
blacklisted-name,
7777
line-too-long,
78-
78+
7979
abstract-class-instantiated,
8080
abstract-method,
8181
access-member-before-definition,
@@ -184,26 +184,26 @@ enable =
184184
used-before-assignment,
185185
using-constant-test,
186186
yield-outside-function,
187-
187+
188188
astroid-error,
189189
fatal,
190190
method-check-failed,
191191
parse-error,
192192
raw-checker-failed,
193-
193+
194194
empty-docstring,
195195
invalid-characters-in-docstring,
196196
missing-docstring,
197197
wrong-spelling-in-comment,
198198
wrong-spelling-in-docstring,
199-
199+
200200
unused-argument,
201201
unused-import,
202202
unused-variable,
203-
203+
204204
eval-used,
205205
exec-used,
206-
206+
207207
bad-classmethod-argument,
208208
bad-mcs-classmethod-argument,
209209
bad-mcs-method-argument,
@@ -234,30 +234,30 @@ enable =
234234
unneeded-not,
235235
useless-else-on-loop,
236236
wrong-assert-type,
237-
237+
238238
deprecated-method,
239239
deprecated-module,
240-
240+
241241
too-many-boolean-expressions,
242242
too-many-nested-blocks,
243243
too-many-statements,
244-
244+
245245
wildcard-import,
246246
wrong-import-order,
247247
wrong-import-position,
248-
248+
249249
missing-final-newline,
250250
mixed-line-endings,
251251
trailing-newlines,
252252
trailing-whitespace,
253253
unexpected-line-ending-format,
254-
254+
255255
bad-inline-option,
256256
bad-option-value,
257257
deprecated-pragma,
258258
unrecognized-inline-option,
259259
useless-suppression,
260-
disable =
260+
disable =
261261
bad-indentation,
262262
broad-exception-raised,
263263
consider-using-f-string,
@@ -282,10 +282,10 @@ disable =
282282
unspecified-encoding,
283283
unused-wildcard-import,
284284
use-maxsplit-arg,
285-
285+
286286
feature-toggle-needs-doc,
287287
illegal-waffle-usage,
288-
288+
289289
logging-fstring-interpolation,
290290
import-outside-toplevel,
291291
inconsistent-return-statements,
@@ -314,6 +314,18 @@ disable =
314314
c-extension-no-member,
315315
no-name-in-module,
316316
unnecessary-lambda-assignment,
317+
too-many-positional-arguments,
318+
possibly-used-before-assignment,
319+
use-dict-literal,
320+
useless-return,
321+
superfluous-parens,
322+
logging-not-lazy,
323+
broad-exception-caught,
324+
no-else-raise,
325+
pointless-exception-statement,
326+
consider-using-join,
327+
use-yield-from,
328+
used-before-assignment,
317329

318330
[REPORTS]
319331
output-format = text
@@ -356,7 +368,7 @@ ignore-imports = no
356368
ignore-mixin-members = yes
357369
ignored-classes = SQLObject
358370
unsafe-load-any-extension = yes
359-
generated-members =
371+
generated-members =
360372
REQUEST,
361373
acl_users,
362374
aq_parent,
@@ -382,7 +394,7 @@ generated-members =
382394
[VARIABLES]
383395
init-import = no
384396
dummy-variables-rgx = _|dummy|unused|.*_unused
385-
additional-builtins =
397+
additional-builtins =
386398

387399
[CLASSES]
388400
defining-attr-methods = __init__,__new__,setUp
@@ -403,11 +415,11 @@ max-public-methods = 20
403415

404416
[IMPORTS]
405417
deprecated-modules = regsub,TERMIOS,Bastion,rexec
406-
import-graph =
407-
ext-import-graph =
408-
int-import-graph =
418+
import-graph =
419+
ext-import-graph =
420+
int-import-graph =
409421

410422
[EXCEPTIONS]
411423
overgeneral-exceptions = builtins.Exception
412424

413-
# e624ea03d8124aa9cf2e577f830632344a0a07d9
425+
# 86de3cc2b03ecf7e6f6f9f2d5f790bb9e7c3eb4c

‎pylintrc_tweaks

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@ disable+ =
3333
c-extension-no-member,
3434
no-name-in-module,
3535
unnecessary-lambda-assignment,
36+
too-many-positional-arguments,
37+
possibly-used-before-assignment,
38+
use-dict-literal,
39+
useless-return,
40+
superfluous-parens,
41+
logging-not-lazy,
42+
broad-exception-caught,
43+
no-else-raise,
44+
pointless-exception-statement,
45+
consider-using-join,
46+
use-yield-from,
47+
used-before-assignment,
48+
3649

3750
[BASIC]
3851
attr-rgx = [a-z_][a-z0-9_]{2,40}$

‎requirements/constraints.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,6 @@ path<16.12.0
149149
# Constraint can be removed once the issue https://github.com/PyCQA/pycodestyle/issues/1090 is fixed.
150150
pycodestyle<2.9.0
151151

152-
# Date: 2021-07-12
153-
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/33560
154-
pylint<2.16.0 # greater version failing quality test. Fix them in seperate ticket.
155-
astroid<2.14.0
156-
157152
# Date: 2021-08-25
158153
# At the time of writing this comment, we do not know whether py2neo>=2022
159154
# will support our currently-deployed Neo4j version (3.5).

‎requirements/edx-sandbox/base.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ cryptography==44.0.0
2020
# via -r requirements/edx-sandbox/base.in
2121
cycler==0.12.1
2222
# via matplotlib
23-
fonttools==4.55.5
23+
fonttools==4.55.6
2424
# via matplotlib
2525
joblib==1.4.2
2626
# via nltk

‎requirements/edx/base.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ asgiref==3.8.1
3737
# django-countries
3838
asn1crypto==1.5.1
3939
# via snowflake-connector-python
40-
attrs==24.3.0
40+
attrs==25.1.0
4141
# via
4242
# -r requirements/edx/kernel.in
4343
# aiohttp
@@ -72,13 +72,13 @@ bleach[css]==6.2.0
7272
# xblock-poll
7373
boto==2.49.0
7474
# via -r requirements/edx/kernel.in
75-
boto3==1.36.5
75+
boto3==1.36.6
7676
# via
7777
# -r requirements/edx/kernel.in
7878
# django-ses
7979
# fs-s3fs
8080
# ora2
81-
botocore==1.36.5
81+
botocore==1.36.6
8282
# via
8383
# -r requirements/edx/kernel.in
8484
# boto3
@@ -1040,7 +1040,7 @@ redis==5.2.1
10401040
# via
10411041
# -r requirements/edx/kernel.in
10421042
# walrus
1043-
referencing==0.36.1
1043+
referencing==0.36.2
10441044
# via
10451045
# jsonschema
10461046
# jsonschema-specifications

‎requirements/edx/development.txt

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -82,15 +82,14 @@ asn1crypto==1.5.1
8282
# -r requirements/edx/doc.txt
8383
# -r requirements/edx/testing.txt
8484
# snowflake-connector-python
85-
astroid==2.13.5
85+
astroid==3.3.8
8686
# via
87-
# -c requirements/edx/../constraints.txt
8887
# -r requirements/edx/doc.txt
8988
# -r requirements/edx/testing.txt
9089
# pylint
9190
# pylint-celery
9291
# sphinx-autoapi
93-
attrs==24.3.0
92+
attrs==25.1.0
9493
# via
9594
# -r requirements/edx/doc.txt
9695
# -r requirements/edx/testing.txt
@@ -145,14 +144,14 @@ boto==2.49.0
145144
# via
146145
# -r requirements/edx/doc.txt
147146
# -r requirements/edx/testing.txt
148-
boto3==1.36.5
147+
boto3==1.36.6
149148
# via
150149
# -r requirements/edx/doc.txt
151150
# -r requirements/edx/testing.txt
152151
# django-ses
153152
# fs-s3fs
154153
# ora2
155-
botocore==1.36.5
154+
botocore==1.36.6
156155
# via
157156
# -r requirements/edx/doc.txt
158157
# -r requirements/edx/testing.txt
@@ -766,7 +765,7 @@ edx-i18n-tools==1.5.0
766765
# -r requirements/edx/testing.txt
767766
# ora2
768767
# xblocks-contrib
769-
edx-lint==5.5.0
768+
edx-lint==5.6.0
770769
# via -r requirements/edx/testing.txt
771770
edx-milestones==0.6.0
772771
# via
@@ -1170,11 +1169,6 @@ lazy==1.6
11701169
# lti-consumer-xblock
11711170
# ora2
11721171
# xblock
1173-
lazy-object-proxy==1.10.0
1174-
# via
1175-
# -r requirements/edx/doc.txt
1176-
# -r requirements/edx/testing.txt
1177-
# astroid
11781172
libsass==0.10.0
11791173
# via
11801174
# -c requirements/edx/../constraints.txt
@@ -1613,9 +1607,8 @@ pylatexenc==2.10
16131607
# -r requirements/edx/doc.txt
16141608
# -r requirements/edx/testing.txt
16151609
# olxcleaner
1616-
pylint==2.15.10
1610+
pylint==3.3.3
16171611
# via
1618-
# -c requirements/edx/../constraints.txt
16191612
# -r requirements/edx/testing.txt
16201613
# edx-lint
16211614
# pylint-celery
@@ -1626,7 +1619,7 @@ pylint-celery==0.3
16261619
# via
16271620
# -r requirements/edx/testing.txt
16281621
# edx-lint
1629-
pylint-django==2.5.5
1622+
pylint-django==2.6.1
16301623
# via
16311624
# -r requirements/edx/testing.txt
16321625
# edx-lint
@@ -1635,7 +1628,7 @@ pylint-plugin-utils==0.8.2
16351628
# -r requirements/edx/testing.txt
16361629
# pylint-celery
16371630
# pylint-django
1638-
pylint-pytest==0.3.0
1631+
pylint-pytest==1.1.8
16391632
# via -r requirements/edx/testing.txt
16401633
pylti1p3==2.0.0
16411634
# via
@@ -1699,7 +1692,7 @@ pysrt==1.1.2
16991692
# -r requirements/edx/doc.txt
17001693
# -r requirements/edx/testing.txt
17011694
# edxval
1702-
pytest==8.3.4
1695+
pytest==8.2.0
17031696
# via
17041697
# -r requirements/edx/testing.txt
17051698
# pylint-pytest
@@ -1718,7 +1711,7 @@ pytest-django==4.9.0
17181711
# via -r requirements/edx/testing.txt
17191712
pytest-json-report==1.5.0
17201713
# via -r requirements/edx/testing.txt
1721-
pytest-metadata==1.8.0
1714+
pytest-metadata==3.1.1
17221715
# via
17231716
# -r requirements/edx/testing.txt
17241717
# pytest-json-report
@@ -1816,7 +1809,7 @@ redis==5.2.1
18161809
# -r requirements/edx/doc.txt
18171810
# -r requirements/edx/testing.txt
18181811
# walrus
1819-
referencing==0.36.1
1812+
referencing==0.36.2
18201813
# via
18211814
# -r requirements/edx/doc.txt
18221815
# -r requirements/edx/testing.txt
@@ -2246,7 +2239,6 @@ wrapt==1.17.2
22462239
# via
22472240
# -r requirements/edx/doc.txt
22482241
# -r requirements/edx/testing.txt
2249-
# astroid
22502242
xblock[django]==5.1.1
22512243
# via
22522244
# -r requirements/edx/doc.txt

0 commit comments

Comments
 (0)