Skip to content

Commit 5d937b0

Browse files
committed
refactor: apply review suggestions
1 parent bd9014a commit 5d937b0

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

openedx/core/djangoapps/content/course_overviews/signals.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,3 @@ def _check_for_display_name_change(previous_course_overview, updated_course_over
232232
old_name=previous_course_overview.display_name_with_default,
233233
new_name=updated_course_overview.display_name_with_default,
234234
)
235-
# update_course_name_in_upstream_links.delay(
236-
# str(previous_course_overview.id),
237-
# updated_course_overview.display_name_with_default
238-
# )

openedx/core/djangoapps/content_libraries/api.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1959,13 +1959,12 @@ def create_or_update_xblock_upstream_link(xblock, course_key: str, course_name:
19591959
Create or update upstream->downstream link in database for given xblock.
19601960
"""
19611961
if not xblock.upstream:
1962-
log.info(f"No upstream found for xblock: {xblock.usage_key}")
19631962
return None
19641963
upstream_usage_key = UsageKeyV2.from_string(xblock.upstream)
19651964
try:
19661965
lib_component = get_component_from_usage_key(upstream_usage_key)
19671966
except ObjectDoesNotExist:
1968-
log.exception("Library block not found!")
1967+
log.error(f"Library component not found for {upstream_usage_key}")
19691968
lib_component = None
19701969
authoring_api.update_or_create_entity_link(
19711970
lib_component,

openedx/core/djangoapps/content_libraries/tasks.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ def create_or_update_xblock_upstream_link(usage_key):
183183
ensure_cms("create_or_update_xblock_upstream_link may only be executed in a CMS context")
184184
xblock = modulestore().get_item(UsageKey.from_string(usage_key))
185185
if not xblock.upstream or not xblock.upstream_version:
186-
TASK_LOGGER.info(f"No upstream or upstream_version found for xblock: {xblock.usage_key}")
187186
return
188187
try:
189188
course_name = CourseOverview.get_from_id(xblock.course_id).display_name_with_default

0 commit comments

Comments
 (0)