Skip to content

fix: enable pylint warnings#36195

Merged
UsamaSadiq merged 2 commits intomasterfrom
usamasadiq/fix-quality-warnings-I
Jan 30, 2025
Merged

fix: enable pylint warnings#36195
UsamaSadiq merged 2 commits intomasterfrom
usamasadiq/fix-quality-warnings-I

Conversation

@UsamaSadiq
Copy link
Member

Description

  • Remove disabled pylint warnings in pylintrc
  • Fix the warnings resulting in the failure of quality checks.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 30, 2025
@openedx openedx deleted a comment from openedx-webhooks Jan 30, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 30, 2025

Thanks for the pull request, @UsamaSadiq!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@UsamaSadiq UsamaSadiq marked this pull request as ready for review January 30, 2025 10:43
@UsamaSadiq UsamaSadiq requested review from a team as code owners January 30, 2025 10:43
@UsamaSadiq UsamaSadiq force-pushed the usamasadiq/fix-quality-warnings-I branch from 79684a5 to 5037a79 Compare January 30, 2025 11:06
@UsamaSadiq UsamaSadiq merged commit b6828ce into master Jan 30, 2025
48 checks passed
@UsamaSadiq UsamaSadiq deleted the usamasadiq/fix-quality-warnings-I branch January 30, 2025 12:15
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jan 30, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

leoaulasneo98 pushed a commit to aulasneo/edx-platform that referenced this pull request Jan 30, 2025
* fix: enable pylint warnings
jciasenza pushed a commit to jciasenza/edx-platform that referenced this pull request Feb 25, 2025
* fix: enable pylint warnings
UsamaSadiq added a commit that referenced this pull request May 14, 2025
* fix: enable pylint warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants