Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for design tokens and CSS variables #862

Closed
wants to merge 1 commit into from

Conversation

xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Aug 28, 2023

WIP: Adds support for styling using a runtime theming as implemented in openedx/frontend-platform#440

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xitij2000 Kshitij Sobti
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 28, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 28, 2023

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@mphilbrick211
Copy link

Hi @xitij2000! Just seeing if this is OK to close?

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Oct 24, 2023
@xitij2000
Copy link
Contributor Author

xitij2000 commented Oct 25, 2023

Hi @xitij2000! Just seeing if this is OK to close?

This is laying groundwork for the design tokens work going in openedx/frontend-platform#440

So I'll leave it in draft and update it to work with the latest changes till that PR is merged and available.

@mphilbrick211 mphilbrick211 removed the inactive PR author has been unresponsive for several months label Nov 14, 2023
@Mashal-m
Copy link
Contributor

Hey @xitij2000, What is the current status of this PR, is it ready to review and merge?
Could you please resolve conflicts?

@mphilbrick211
Copy link

Hey @xitij2000, What is the current status of this PR, is it ready to review and merge? Could you please resolve conflicts?

Hi @xitij2000 - just following up to see if this can be closed?

@xitij2000
Copy link
Contributor Author

Hey @xitij2000, What is the current status of this PR, is it ready to review and merge? Could you please resolve conflicts?

Hi @xitij2000 - just following up to see if this can be closed?

I'll close it for now and reopen when the relevant PR openedx/frontend-platform#440 is merged.

@mphilbrick211
Copy link

Closing per comment above.

@openedx-webhooks
Copy link

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants