Skip to content

Commit e10ab27

Browse files
bradenmacdonaldbradenmacdonald
authored
chore: don't name unused errors in catch expressions (#2591)
1 parent a5d65ab commit e10ab27

File tree

50 files changed

+110
-110
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+110
-110
lines changed

‎plugins/course-apps/xpert_unit_summary/data/thunks.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export function updateXpertSettings(courseId, state) {
1919
}
2020
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
2121
return false;
22-
} catch (error) {
22+
} catch {
2323
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
2424
return false;
2525
}
@@ -33,7 +33,7 @@ export function fetchXpertPluginConfigurable(courseId) {
3333
try {
3434
const { response } = await getXpertPluginConfigurable(courseId);
3535
enabled = response?.enabled;
36-
} catch (e) {
36+
} catch {
3737
enabled = undefined;
3838
}
3939

@@ -55,7 +55,7 @@ export function fetchXpertSettings(courseId) {
5555
try {
5656
const { response } = await getXpertSettings(courseId);
5757
enabled = response?.enabled;
58-
} catch (e) {
58+
} catch {
5959
enabled = undefined;
6060
}
6161

@@ -86,7 +86,7 @@ export function removeXpertSettings(courseId) {
8686
}
8787
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
8888
return false;
89-
} catch (error) {
89+
} catch {
9090
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
9191
return false;
9292
}
@@ -105,7 +105,7 @@ export function resetXpertSettings(courseId, state) {
105105
}
106106
dispatch(updateResetStatus({ status: RequestStatus.FAILED }));
107107
return false;
108-
} catch (error) {
108+
} catch {
109109
dispatch(updateResetStatus({ status: RequestStatus.FAILED }));
110110
return false;
111111
}

‎src/advanced-settings/data/thunks.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export function updateCourseAppSetting(courseId, settings) {
5858
try {
5959
const { customAttributes: { httpErrorResponseData } } = error;
6060
errorData = JSON.parse(httpErrorResponseData);
61-
} catch (err) {
61+
} catch {
6262
errorData = {};
6363
}
6464

@@ -77,7 +77,7 @@ export function fetchProctoringExamErrors(courseId) {
7777
const settingValues = await getProctoringExamErrors(courseId);
7878
dispatch(fetchProctoringExamErrorsSuccess(settingValues));
7979
return true;
80-
} catch (error) {
80+
} catch {
8181
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
8282
return false;
8383
}

‎src/advanced-settings/utils.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default function validateAdvancedSettingsData(settingObj, setErrorFields,
1717
Object.entries(settingObj).forEach(([settingName, settingValue]) => {
1818
try {
1919
JSON.parse(settingValue);
20-
} catch (e) {
20+
} catch {
2121
let targetSettingValue = settingValue;
2222
const firstNonWhite = settingValue.substring(0, 1);
2323
const isValid = !['{', '[', "'"].includes(firstNonWhite);
@@ -30,7 +30,7 @@ export default function validateAdvancedSettingsData(settingObj, setErrorFields,
3030
...prevEditedSettings,
3131
[settingName]: targetSettingValue,
3232
}));
33-
} catch (quotedE) { /* empty */ }
33+
} catch { /* empty */ }
3434
}
3535

3636
pushDataToErrorArray(settingName);

‎src/course-checklist/data/thunks.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export function fetchCourseBestPracticesQuery({
4343
const data = await getCourseBestPractices({ courseId, excludeGraded, all });
4444
dispatch(fetchBestPracticeChecklistSuccess({ data }));
4545
dispatch(updateBestPracticeChecklisttStatus({ status: RequestStatus.SUCCESSFUL }));
46-
} catch (error) {
46+
} catch {
4747
dispatch(updateBestPracticeChecklisttStatus({ status: RequestStatus.FAILED }));
4848
}
4949
};

‎src/course-libraries/ReviewTabContent.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ const ItemReviewList = ({
224224
messages.updateSingleBlockSuccess,
225225
{ name: info.displayName },
226226
));
227-
} catch (e) {
227+
} catch {
228228
showToast(intl.formatMessage(previewChangesMessages.acceptChangesFailure));
229229
}
230230
}, []);
@@ -243,7 +243,7 @@ const ItemReviewList = ({
243243
messages.ignoreSingleBlockSuccess,
244244
{ name: blockData.displayName },
245245
));
246-
} catch (e) {
246+
} catch {
247247
showToast(intl.formatMessage(previewChangesMessages.ignoreChangesFailure));
248248
} finally {
249249
closeConfirmModal();

‎src/course-outline/data/thunk.ts‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export function fetchCourseBestPracticesQuery({
148148
dispatch(fetchStatusBarChecklistSuccess(getCourseBestPracticesChecklist(data)));
149149

150150
return true;
151-
} catch (error) {
151+
} catch {
152152
return false;
153153
}
154154
};
@@ -165,7 +165,7 @@ export function enableCourseHighlightsEmailsQuery(courseId: string) {
165165

166166
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
167167
dispatch(hideProcessingNotification());
168-
} catch (error) {
168+
} catch {
169169
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
170170
}
171171
};
@@ -182,7 +182,7 @@ export function setVideoSharingOptionQuery(courseId: string, option: string) {
182182

183183
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
184184
dispatch(hideProcessingNotification());
185-
} catch (error) {
185+
} catch {
186186
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
187187
dispatch(hideProcessingNotification());
188188
}
@@ -260,7 +260,7 @@ export function updateCourseSectionHighlightsQuery(sectionId: string, highlights
260260
dispatch(hideProcessingNotification());
261261
}
262262
});
263-
} catch (error) {
263+
} catch {
264264
dispatch(hideProcessingNotification());
265265
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
266266
}
@@ -280,7 +280,7 @@ export function publishCourseItemQuery(itemId: string, sectionId: string) {
280280
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
281281
}
282282
});
283-
} catch (error) {
283+
} catch {
284284
dispatch(hideProcessingNotification());
285285
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
286286
}
@@ -300,7 +300,7 @@ export function configureCourseItemQuery(sectionId: string, configureFn: () => P
300300
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
301301
}
302302
});
303-
} catch (error) {
303+
} catch {
304304
dispatch(hideProcessingNotification());
305305
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
306306
}
@@ -390,7 +390,7 @@ export function editCourseItemQuery(itemId: string, sectionId: string, displayNa
390390
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
391391
}
392392
});
393-
} catch (error) {
393+
} catch {
394394
dispatch(hideProcessingNotification());
395395
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
396396
}
@@ -412,7 +412,7 @@ function deleteCourseItemQuery(itemId: string, deleteItemFn: () => {}) {
412412
dispatch(deleteItemFn());
413413
dispatch(hideProcessingNotification());
414414
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
415-
} catch (error) {
415+
} catch {
416416
dispatch(hideProcessingNotification());
417417
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
418418
}
@@ -469,7 +469,7 @@ function duplicateCourseItemQuery(
469469
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
470470
}
471471
});
472-
} catch (error) {
472+
} catch {
473473
dispatch(hideProcessingNotification());
474474
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
475475
}
@@ -541,7 +541,7 @@ function addNewCourseItemQuery(
541541
dispatch(hideProcessingNotification());
542542
}
543543
});
544-
} catch (error) {
544+
} catch {
545545
dispatch(hideProcessingNotification());
546546
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
547547
}
@@ -612,7 +612,7 @@ export function addUnitFromLibrary(body: {
612612
callback(result.locator);
613613
}
614614
});
615-
} catch (error) /* istanbul ignore next */ {
615+
} catch /* istanbul ignore next */ {
616616
dispatch(hideProcessingNotification());
617617
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
618618
}
@@ -643,7 +643,7 @@ function setBlockOrderListQuery(
643643
dispatch(hideProcessingNotification());
644644
}
645645
});
646-
} catch (error) {
646+
} catch {
647647
restoreCallback();
648648
dispatch(hideProcessingNotification());
649649
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
@@ -728,7 +728,7 @@ export function pasteClipboardContent(parentLocator: string, sectionId: string)
728728
dispatch(setPasteFileNotices(result?.staticFileNotices));
729729
}
730730
});
731-
} catch (error) {
731+
} catch {
732732
dispatch(hideProcessingNotification());
733733
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
734734
}
@@ -743,7 +743,7 @@ export function dismissNotificationQuery(url: string) {
743743
await dismissNotification(url).then(async () => {
744744
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
745745
});
746-
} catch (error) {
746+
} catch {
747747
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
748748
}
749749
};

‎src/course-outline/hooks.jsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ const useCourseOutline = ({ courseId }) => {
159159
data.shouldScroll = true;
160160
// Page should scroll to newly added subsection.
161161
dispatch(addSubsection({ parentLocator, data }));
162-
} catch (error) {
162+
} catch {
163163
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
164164
}
165165
});
@@ -174,7 +174,7 @@ const useCourseOutline = ({ courseId }) => {
174174
// Page should scroll to newly added section.
175175
data.shouldScroll = true;
176176
dispatch(addSection(data));
177-
} catch (error) {
177+
} catch {
178178
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
179179
}
180180
});

‎src/course-team/data/thunk.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export function changeRoleTeamUserQuery(courseId, email, role) {
6666

6767
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
6868
return true;
69-
} catch ({ message }) {
69+
} catch {
7070
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
7171
return false;
7272
}
@@ -83,7 +83,7 @@ export function deleteCourseTeamQuery(courseId, email) {
8383

8484
dispatch(updateSavingStatus({ status: RequestStatus.SUCCESSFUL }));
8585
return true;
86-
} catch (error) {
86+
} catch {
8787
dispatch(updateSavingStatus({ status: RequestStatus.FAILED }));
8888
return false;
8989
}

‎src/course-unit/data/thunk.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export function fetchCourseSectionVerticalData(courseId, sequenceId) {
5858
localStorage.removeItem('staticFileNotices');
5959
dispatch(fetchSequenceSuccess({ sequenceId }));
6060
return true;
61-
} catch (error) {
61+
} catch {
6262
dispatch(updateLoadingCourseSectionVerticalDataStatus({ status: RequestStatus.FAILED }));
6363
dispatch(fetchSequenceFailure({ sequenceId }));
6464
return false;
@@ -204,7 +204,7 @@ export function fetchCourseVerticalChildrenData(itemId, isSplitTestType, skipPag
204204
}
205205
dispatch(updateCourseVerticalChildren(courseVerticalChildrenData));
206206
dispatch(updateCourseVerticalChildrenLoadingStatus({ status: RequestStatus.SUCCESSFUL }));
207-
} catch (error) {
207+
} catch {
208208
dispatch(updateCourseVerticalChildrenLoadingStatus({ status: RequestStatus.FAILED }));
209209
}
210210
};

‎src/course-unit/preview-changes/index.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export const PreviewLibraryXBlockChanges = ({
177177
overrideCustomizations,
178178
});
179179
postChange(accept);
180-
} catch (e) {
180+
} catch {
181181
showToast(intl.formatMessage(failureMsg));
182182
} finally {
183183
closeModal();

0 commit comments

Comments
 (0)