feat: Adds display name attribute to subsidy access policy creation API #365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 161 161
Lines 3417 3417
Branches 841 841
=======================================
Hits 3021 3021
Misses 393 393
Partials 3 3 ☔ View full report in Codecov by Sentry. |
| @@ -503,6 +504,7 @@ export function transformPolicyData(formData, catalogCreationResponse, subsidyCr | |||
| || subsidyCreationResponse.length === 0 | |||
| ) { return []; } | |||
| const payloads = policies.map((policy, index) => ({ | |||
| displayName: policy.accountName, | |||
There was a problem hiding this comment.
[nit, question, non-blocking] What does account refer to here? I'm wondering if it might make sense to more closely align the property names to how the API returns these attributes? That said, if we take any action here, definitely for a separate PR given unrelated variable names, etc. would also need to change.
For example, at first glance, it's not immediately obvious to me that accountName is referring to the display name of a budget; initially, I had read "account" to mean mean the enterprise customer, not the budget itself (e.g., is policy.accountName the enterprise customer name?).
There was a problem hiding this comment.
Agreed on the sentiment for the renaming of the object attributes. I know theres an upcoming PR that revamps some of the naming scheme to be more understandable, so it was intentional to keep this PR as simple as possible.
But I will definitely leave this comment open as a reference to when we do have to take on that future work. 👍🏽
Adds
display_nameto the subsidy access policy POST method and related data transformation functions.