fix: can create new plans with test plan unchecked #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
- Coverage 88.07% 88.07% -0.01%
==========================================
Files 161 161
Lines 3364 3362 -2
Branches 828 827 -1
==========================================
- Hits 2963 2961 -2
Misses 397 397
Partials 4 4 ☔ View full report in Codecov by Sentry. |
pwnage101
commented
Dec 11, 2023
Comment on lines
+23
to
+24
| // `internalOnly` backs the "Test plan" checkbox. A true value means the plan will not be customer facing. | ||
| internalOnly: false, |
There was a problem hiding this comment.
This line fixes the bug.
pwnage101
commented
Dec 11, 2023
Comment on lines
-14
to
+16
| let submittedFormInternalOnly; | ||
| if (isEditMode) { | ||
| submittedFormInternalOnly = formData.internalOnly; | ||
| } | ||
| const [value, setValue] = useState(submittedFormInternalOnly || false); | ||
| // formData.internalOnly is always defined, whether it's hydrated from an API call (isEditMode = true) or not | ||
| // (isEditMode = false) in which case ProvisioningContextProvider supplies a default. | ||
| const [value, setValue] = useState(formData.internalOnly || false); |
There was a problem hiding this comment.
Since we can assume that formData.internalOnly is always defined, we can kill the if-condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow we let a regression slip through manual QA testing and unit testing which prevented non-test plans from being created. The provisioning tool would POST to create a subsidy, but failed to supply a
default_internal_onlyrequest parameter, which is required. This change adds a default value for formData.internalOnly on context initialization to prevent the field from ever being empty.ENT-8107
testing done