feat: add functionality to remove username from header #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 88.10% 92.30% +4.19%
==========================================
Files 162 161 -1
Lines 3380 3365 -15
Branches 836 833 -3
==========================================
+ Hits 2978 3106 +128
+ Misses 398 253 -145
- Partials 4 6 +2 ☔ View full report in Codecov by Sentry. |
zainab-amir
force-pushed
the
zamir/VAN-1805/remove_username
branch
2 times, most recently
from
cb1d98f to
8136e74
Compare
* Added a new environment variable that controls whether we want to remove username from header * Updated header component to hide username VAN-1805
zainab-amir
force-pushed
the
zamir/VAN-1805/remove_username
branch
from
8136e74 to
c075a5c
Compare
|
We have decided not to make changes to custom header and instead wait for this MFE to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of making registration experience quick and easy (more details on MVP scope doc), we want to be able to remove username from the registration form. This creates the need to remove it everywhere on the UX too. As part of this initiative, we will be removing username from the headers and making the dropdown consistent with edx.org site.
We have kept this change behind the
HIDE_USERNAME_FROM_HEADERenvironment variable. By default, this feature is turned off.VAN-1805