Add comment to course reset #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 88.34% 88.35% +0.01%
==========================================
Files 164 164
Lines 3448 3462 +14
Branches 850 856 +6
==========================================
+ Hits 3046 3059 +13
- Misses 398 399 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
hajorg
requested review from
jansenk,
leangseu-edx,
Rodra,
BrandonHBodine and
nsprenkle
AfaqShuaib09
approved these changes
Mar 29, 2024
src/users/CourseReset.jsx
Outdated
| @@ -17,8 +17,20 @@ function CourseReset({ username, intl }) { | |||
| const [courseResetData, setCourseResetData] = useState([]); | |||
| const [error, setError] = useState(''); | |||
| const [isOpen, open, close] = useToggle(false); | |||
| const [comment, setComment] = useState(); | |||
There was a problem hiding this comment.
Suggested change
| const [comment, setComment] = useState(); | |
| const [comment, setComment] = useState(''); |
src/users/CourseReset.jsx
Outdated
| const handleCommentChange = (e) => { | ||
| const text = e.target.value; | ||
| setComment(text); | ||
| if (text.length > 255) { |
There was a problem hiding this comment.
would be nice if we store this 255 in a variable
MAX_COMMENT_LENGTH = 255so we can use this in comment message error too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows for comment to be added when resetting a learner's course
See: https://2u-internal.atlassian.net/browse/AU-1935