Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic-116&266: add source system column and update order number href for enrollments table #380

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

NawfalAhmed
Copy link
Member

Description

  • Add source system column in enrollments table, defaults to N/A
  • Update the OrderNumber link for enrollments table to point to commerce coordinater if the flag is set

Supporting Information

Jira Tickets: Sonic-266, Sonic-116

@NawfalAhmed NawfalAhmed changed the title [Sonic:266+Sonic-116]: add source system column and update order number href for enrollments table Sonic-116&266: add source system column and update order number href for enrollments table Apr 2, 2024
@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch 2 times, most recently from e51adcc to 5539615 Compare April 2, 2024 22:45
@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from 5539615 to bd6a0c4 Compare April 2, 2024 22:48
@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from fc79eed to 926f9c5 Compare April 2, 2024 23:31
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.28%. Comparing base (da37a62) to head (74b0bf4).

❗ Current head 74b0bf4 differs from pull request most recent head 7eb35fa. Consider uploading reports for the commit 7eb35fa to get more accurate results

Files Patch % Lines
src/users/enrollments/Enrollments.jsx 60.00% 1 Missing and 1 partial ⚠️
src/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   88.35%   88.28%   -0.07%     
==========================================
  Files         164      164              
  Lines        3462     3467       +5     
  Branches      856      861       +5     
==========================================
+ Hits         3059     3061       +2     
- Misses        399      401       +2     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from 74b0bf4 to 7656b42 Compare April 3, 2024 00:00
Copy link
Member

@aht007 aht007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from 7656b42 to e467284 Compare April 8, 2024 15:45
@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from e467284 to 7eb35fa Compare April 8, 2024 15:49
@NawfalAhmed NawfalAhmed self-assigned this Apr 8, 2024
@NawfalAhmed NawfalAhmed force-pushed the nahmed/sonic-266/update-order-number-href branch from 624adff to 7eb35fa Compare April 8, 2024 17:56
@NawfalAhmed NawfalAhmed merged commit e65f259 into master Apr 16, 2024
13 checks passed
@NawfalAhmed NawfalAhmed deleted the nahmed/sonic-266/update-order-number-href branch April 16, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants