fix: add integration count number #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,12 +11,16 @@ const CustomerIntegrations = ({ | |||
| const { ADMIN_PORTAL_BASE_URL } = getConfig(); | |||
| const ssoDateText = ({ sso }) => (`Created ${formatDate(sso?.created)} • Last modified ${formatDate(sso?.modifed)}`); | |||
| const configDateText = ({ config }) => (`Created ${formatDate(config?.created)} • Last modified ${formatDate(config?.lastModifiedAt)}`); | |||
| let integrationCount = activeSSO?.length + activeIntegrations?.length; | |||
There was a problem hiding this comment.
Is there any chance that activeSSO or activeIntegrations will be undefined? If so, we're going to get either undefined or NaN out of this expression, which will mess up all future operations on this value.
marlonkeating
approved these changes
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 84.47% 84.49% +0.01%
==========================================
Files 185 185
Lines 3814 3817 +3
Branches 920 922 +2
==========================================
+ Hits 3222 3225 +3
Misses 570 570
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a count of the number of integrations associated with that customer
Jira ticket