Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zero state for customer view headers #415

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Sep 9, 2024

Description

Adds logic to handle zero states in the customer view page.

  1. Hide the “Show inactive” toggle instead of disabling it if a customer does not have inactive plans.
  2. Hide the "Associated subsidy plan" header if the customer does not have inactive or active plans.
  3. Hide the "Associated integrations" header if the customer does not have active integrations.
  4. Hide the "Associated users" header if the customer does not have users.

Test Plan on Stage

  1. checkout branch knguyen2/ent-9447 and run npm install
  2. at the root directory, add file webpack.dev.config.js with the following content:
const { createConfig } = require('@openedx/frontend-build');

module.exports = createConfig('webpack-dev', {
  devServer: {
    allowedHosts: 'all',
    https: true,
  },
});
  1. replace the content in .env.development with this info:
NODE_ENV='development'
PORT=18450
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
ADMIN_PORTAL_BASE_URL='https://portal.stage.edx.org'
ACCESS_TOKEN_COOKIE_NAME='stage-edx-jwt-cookie-header-payload'
BASE_URL='https://localhost.stage.edx.org:18450'
FEATURE_CONFIGURATION_MANAGEMENT='true'
FEATURE_CONFIGURATION_ENTERPRISE_PROVISION='true'
FEATURE_CONFIGURATION_EDIT_ENTERPRISE_PROVISION='true'
CREDENTIALS_BASE_URL='https://credentials.stage.edx.org'
CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
ECOMMERCE_BASE_URL='https://ecommerce.stage.edx.org'
ENTERPRISE_ACCESS_BASE_URL='https://enterprise-access.stage.edx.org'
LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference'
LMS_BASE_URL='https://courses.stage.edx.org'
LICENSE_MANAGER_URL='https://license-manager-internal.stage.edx.org'
SUPPORT_CONFLUENCE='https://support-tools.edx.org'
SUPPORT_CUSTOMER_REQUEST='https://support-tools.edx.org'
DISCOVERY_API_BASE_URL='https://discovery.stage.edx.org'
LOGIN_URL='https://courses.stage.edx.org/login'
LOGOUT_URL='https://courses.stage.edx.org/logout'
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='https://stage.edx.org'
ORDER_HISTORY_URL='https://orders.stage.edx.org/orders'
REFRESH_ACCESS_TOKEN_ENDPOINT='https://courses.stage.edx.org/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
SUBSIDY_BASE_URL='https://enterprise-subsidy.stage.edx.org'
USER_INFO_COOKIE_NAME='edx-user-info'
PUBLISHER_BASE_URL='https://publisher.stage.edx.org/'
APP_ID='support-tools'
MFE_CONFIG_API_URL='https://courses.stage.edx.org/api/mfe_config/v1'
  1. verify that you do not see the “Show inactive” toggle for the following customer: https://support-tools.stage.edx.org/enterprise-configuration/customers/66b5922b-a22b-4a7b-b587-d4af0378bd6f/view
  2. verify that you do not see the “Associated subsidy plans” header for the following customer: https://support-tools.stage.edx.org/enterprise-configuration/customers/beafadc5-69cc-48ce-a9a1-532067d9af0f/view
  3. verify that you do not see the “Associated integrations” header for the following customer: https://support-tools.stage.edx.org/enterprise-configuration/customers/5d78a4d4-87a3-4db4-b665-2bcaf922edba/view
  4. verify that you do not see the “Associated users” header for the following customer: https://support-tools.stage.edx.org/enterprise-configuration/customers/beafadc5-69cc-48ce-a9a1-532067d9af0f/view

https://2u-internal.atlassian.net/browse/ENT-9447

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (c6ed509) to head (6c963e6).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...omers/CustomerDetailView/CustomerPlanContainer.jsx 80.00% 2 Missing ⚠️
...omers/CustomerDetailView/CustomerViewContainer.jsx 77.77% 2 Missing ⚠️
.../Customers/data/hooks/useCustomerUsersTableData.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   84.49%   84.75%   +0.26%     
==========================================
  Files         185      185              
  Lines        3817     3856      +39     
  Branches      912      938      +26     
==========================================
+ Hits         3225     3268      +43     
+ Misses        570      566       -4     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good besides the associated users

@katrinan029 katrinan029 requested a review from kiram15 September 12, 2024 15:00
@katrinan029 katrinan029 merged commit 9d06fe6 into master Sep 12, 2024
6 of 7 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9447 branch September 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants