feat: adding link to user page to icon #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 84.31% 84.33% +0.02%
==========================================
Files 185 185
Lines 3850 3855 +5
Branches 943 944 +1
==========================================
+ Hits 3246 3251 +5
Misses 581 581
Partials 23 23 ☔ View full report in Codecov by Sentry. |
katrinan029
approved these changes
Oct 1, 2024
| const memberDetailIcon = () => { | ||
| if (user) { | ||
| return ( | ||
| <Hyperlink destination={iconLink} key={user?.email} data-testId="icon-hyperlink"> |
There was a problem hiding this comment.
I think we should have this open to a new tab with target="_blank" and showLaunchIcon={false}
kiram15
force-pushed
the
kiram15/ENT-9551
branch
from
0310eff to
24ac3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-30.at.2.20.38.PM.mov
Jira
Testing:
kiram15/ENT-9551and runnpm run starthttps://localhost.stage.edx.org:18450/enterprise-configuration/customers/02982884-1f1f-4103-b6d7-3a602c1afcbd/viewand scroll down to member detailshttps://localhost.stage.edx.org:18450/learner_information/?email=LEARNER_EMAIL