Skip to content

Commit 1d835ac

Browse files
authored
docs: adds actual l10n alternative to ADR 10 (#110)
and adds reference links to OEPs
1 parent a7ce025 commit 1d835ac

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

docs/decisions/0010_localization.rst

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ support localized representations of dates and calendars.
2727

2828
Superset provides Aspect's user interface, and it supports a subset of locales for translating/displaying the menus and
2929
pages that the application serves. However, Superset does not translate its application or asset data, i.e. the
30-
dashboards and charts shown to users. Superset also has some open issues related to localization (e.g. `issue#25258`_).
30+
dashboards and charts shown to users. Superset also has some open issues related to localization (e.g. `superset#25258`_).
3131

3232
Aspects must maintain and display translated versions of its supported Superset assets.
3333

@@ -57,17 +57,20 @@ Consequences
5757
Rejected Alternatives
5858
*********************
5959

60-
**Translate assets on the fly with javascript**
60+
**Contribute asset translations to Superset**
6161

62-
Another way to implement translations in the browser is using javascript and a mapping between English words/phrases and
63-
the translated words/phrases (e.g. `simple-translator`_). However, this approach cannot discern the context around how
64-
words/phrases are used, and so providing accurate translations for complex content can be difficult or impossible. This
65-
approach would also slow page load times and would provide a sub-standard user experience.
62+
The Superset community proposed `superset#13442`_ to allow users to provide translations for chart titles, axis labels,
63+
and metric names.
64+
65+
This ticket has since been closed due to inactivity, but because it puts the onus on translations on the Superset users,
66+
it's not a solution that would satisfy the Open edX community, which expects translations to be shipped with the
67+
applications that use them.
6668

6769
References
6870
**********
6971

72+
* `OEP-58`_ Translations management
7073

7174
.. _OEP-58: https://docs.openedx.org/projects/openedx-proposals/en/latest/architectural-decisions/oep-0058-arch-translations-management.html
72-
.. _issue#25258: https://github.com/apache/superset/issues/25258
73-
.. _simple-translator: https://github.com/andreasremdt/simple-translator
75+
.. _superset#25258: https://github.com/apache/superset/issues/25258
76+
.. _superset#13442: https://github.com/apache/superset/issues/13442

0 commit comments

Comments
 (0)