Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure all renamed *Hook.tsx files have the "renamed" note comment #3396

Open
brian-smith-tcril opened this issue Jan 24, 2025 · 0 comments
Open

Comments

@brian-smith-tcril
Copy link
Contributor

In #3395 (comment) I noticed

useArrowKeyNavigationHook, useIndexOfLastVisibleChildHook, and useToggleHook all have variations of

// Note: this file was renamed from 'useIndexOfLastVisibleChild.tsx' to 'useIndexOfLastVisibleChildHook.tsx' to fix
// some bugs in the Gatsby www site, where Webpack was getting the .tsx and .mdx
// files confused. Renaming this file allows us to keep the URLs of the docs site
// unchanged.

at the top of the files. This file (useIsVisibleHook) and useWindowSizeHook were also renamed but do not have those.

Since I noticed that on the sync from release-22.x to release-23.x that felt like the wrong place to recommend the changes.

The best path forward here would be to ensure we those note comments are consistent in all the renamed files on the release-22.x branch - then those changes will make their way into release-23.x and next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant