-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add dataset for pageview engagement charts (FC-0051) #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dataset for pageview engagement charts (FC-0051) #673
Conversation
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@SoryRawyer I haven't had a chance to review yet, but I think the CI errors can be fixed with a rebase |
1f327fa
to
500d847
Compare
@bmtcril I don't think I'm missing any commits from |
500d847
to
869d6ae
Compare
@SoryRawyer can you add this chart to the Instructor Dashboard too? |
I think this is failing due to secrets not being available since you don't have write on the repo. I suspect this will happen with forks, too. We can merge with these failures, but if we don't 100% need those images to build we might want to just skip those when they can't run (if that's even possible)? |
bef0c62
to
21c0d00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this just needs another rebase to get the latest changes to the build-image workflow and it should be good to go!
feat: add pageview engagement chart to instructor dashboard fix: include filters in pageview engagement dataset
21c0d00
to
f62ecb9
Compare
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR adds a dataset that can be used to show the number of learners who have:
This is still a draft because I wanted to give a more elaborate example of how I imagined using the models added in my recent aspects-dbt PR.
Here is a chart that I made from this dataset:
