Skip to content

feat: add dataset for pageview engagement charts (FC-0051) #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

SoryRawyer
Copy link
Contributor

This PR adds a dataset that can be used to show the number of learners who have:

  1. viewed at least one page in a section or subsection
  2. viewed all pages in a section or subsection

This is still a draft because I wanted to give a more elaborate example of how I imagined using the models added in my recent aspects-dbt PR.

Here is a chart that I made from this dataset:
Screenshot from 2024-03-19 14-03-59

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 19, 2024

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bmtcril
Copy link
Contributor

bmtcril commented Mar 19, 2024

@SoryRawyer I haven't had a chance to review yet, but I think the CI errors can be fixed with a rebase

@SoryRawyer SoryRawyer force-pushed the rds/add-pageview-dropoff-dataset branch from 1f327fa to 500d847 Compare March 20, 2024 13:39
@SoryRawyer
Copy link
Contributor Author

@bmtcril I don't think I'm missing any commits from main. Do you have any ideas what else might be causing the Docker hub login step to fail?

@SoryRawyer SoryRawyer marked this pull request as ready for review March 22, 2024 14:05
@SoryRawyer SoryRawyer force-pushed the rds/add-pageview-dropoff-dataset branch from 500d847 to 869d6ae Compare March 22, 2024 14:15
@Ian2012
Copy link
Contributor

Ian2012 commented Mar 22, 2024

@SoryRawyer can you add this chart to the Instructor Dashboard too?

@bmtcril
Copy link
Contributor

bmtcril commented Mar 22, 2024

I think this is failing due to secrets not being available since you don't have write on the repo. I suspect this will happen with forks, too. We can merge with these failures, but if we don't 100% need those images to build we might want to just skip those when they can't run (if that's even possible)?

@SoryRawyer SoryRawyer force-pushed the rds/add-pageview-dropoff-dataset branch 4 times, most recently from bef0c62 to 21c0d00 Compare March 22, 2024 18:08
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this just needs another rebase to get the latest changes to the build-image workflow and it should be good to go!

feat: add pageview engagement chart to instructor dashboard

fix: include filters in pageview engagement dataset
@SoryRawyer SoryRawyer force-pushed the rds/add-pageview-dropoff-dataset branch from 21c0d00 to f62ecb9 Compare March 25, 2024 13:42
@bmtcril bmtcril merged commit a2b0719 into openedx:main Mar 25, 2024
@openedx-webhooks
Copy link

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants