Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chart for full and partial video views (FC-0051) #700

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

SoryRawyer
Copy link
Contributor

This adds a chart to show the number of full and partial views of course videos. This builds on the watched video segments query and compares the number of segments viewed by a learner to the expected number of segments in the video. The number of segments is calculated by first taking ten seconds off the video duration and then calculating the number of segments based on that shortened duration. This is to account for learners who, say, watch the entire video but skip the end credits.

Here is a screenshot of the chart:
Screenshot from 2024-04-08 10-39-30

This adds a chart to show the number of full and partial views of course
videos. This builds on the watched video segments query and compares the
number of segments viewed by a learner to the expected number of
segments in the video. The number of segments is calculated by first
taking ten seconds off the video duration and then calculating the
number of segments based on that shortened duration. This is to account
for learners who, say, watch the entire video but skip the end credits.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012
Copy link
Contributor

Ian2012 commented Apr 8, 2024

Waiting on @bmtcril opinion

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like as good a start as we can ask for, we'll run it through the user tests and performance to see how it all shakes out!

@Ian2012 Ian2012 merged commit 7335c9c into openedx:main Apr 9, 2024
9 checks passed
@openedx-webhooks
Copy link

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants