fix: deletes openedx-dev-dockerfile-post-python-requirements #717
Conversation
openedx-dockerfile-post-python-requirements is sufficient to get these requirements installed on the openedx or openedx-dev image. Having them in openedx-dev-dockerfile-post-python-requirements causes these requirements to be installed twice, and when this one runs at the end of the `tutor images build openedx-dev` process, it overwrites any mounted dependencies, making dev impossible.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Ok.. failing dev tests means this mustn't be right, so closing.. |
|
@pomegranited Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@pomegranited You are right, this will not be needed on Reedwood as the requirement will be already on the latest version. |
The
openedx-dockerfile-post-python-requirementspatch is sufficient to get these requirements installed on the openedx or openedx-dev image.Having them duplicated in
openedx-dev-dockerfile-post-python-requirementscauses these requirements to be installed twice, and when the dev version applies at the end of thetutor images build openedx-devprocess, it overwrites any mounted dependencies, making dev impossible.