Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the release process more repeatable #185

Closed
3 of 4 tasks
kdmccormick opened this issue Jun 9, 2022 · 16 comments
Closed
3 of 4 tasks

Make the release process more repeatable #185

kdmccormick opened this issue Jun 9, 2022 · 16 comments
Assignees
Labels
documentation Relates to documentation improvements enhancement Relates to new features or improvements to existing features
Milestone

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Jun 9, 2022

Existing process: https://openedx.atlassian.net/wiki/spaces/COMM/pages/19662426/Process+to+Create+an+Open+edX+Release#Make-a-release-or-release-candidate

Thing we found during the Nutmeg release that we want to be better next time:

  • All repos should be in openedx org
  • Remove/replace references to native installation
  • The entire release page should be numbered
  • Several other things, listed in comments below, or in the page itself:
@nedbat
Copy link
Contributor

nedbat commented Jun 9, 2022

  • The documentation steps that should have happened when nutmeg.master was made were never done.

@kdmccormick
Copy link
Member Author

kdmccormick commented Jun 9, 2022

  • branch creation script didn't rollback changes when it crashed within do_the_work with a ReadTimeout

@kdmccormick
Copy link
Member Author

kdmccormick commented Jun 9, 2022

  • we have too many release documentation pages (fyi @feanil )

@kdmccormick
Copy link
Member Author

@nedbat
Copy link
Contributor

nedbat commented Jun 9, 2022

  • The week before the release:
    • check all the "maybe" repos
    • check that all the involved repos have permissions for community-release-managers

@kdmccormick
Copy link
Member Author

kdmccormick commented Jun 9, 2022

  • need a step for "last-minute" repos that are added to release, including
    • add it to the release team
    • edit openedx.yaml
    • create the nutmeg.master branch
    • whether to create nutmeg.master from master, or back from the release cut date
    • ensure CI is passing

@kdmccormick
Copy link
Member Author

kdmccormick commented Jun 9, 2022

  • would like to compare list of repos with access to the list of repos we're trying to create branches in (@regisb )

@kdmccormick
Copy link
Member Author

  • wiki page should be update with new additions to tag_release tool, namely the save-the-repo-list-to-a-file feature.

@kdmccormick
Copy link
Member Author

  • maintainers need to backport security fixes into release branches

@kdmccormick
Copy link
Member Author

  • who's job is it to make the blog post?

@nedbat
Copy link
Contributor

nedbat commented Jun 9, 2022

Need a way to check the permissions on all the repos at once. Perhaps a new tag_release option to make-then-delete a branch in each repo sequentially, showing the errors of the ones that fail.

@nedbat
Copy link
Contributor

nedbat commented Jun 9, 2022

The Maple transifex resources are different than Lilac and before. The wiki page says to do it the Lilac way. We don't know who made the Maple resources, probably the translation working group. We need to coordinate and agree on the right approach.

@arbrandes
Copy link
Contributor

Just a ping for us to remember this ticket exists, and to do what we can during the Olive release.

@arbrandes arbrandes moved this from 🏗 In Progress to ⏭ To Do in Build-Test-Release Working Group Dec 6, 2022
@arbrandes arbrandes added enhancement Relates to new features or improvements to existing features and removed type:btr-task labels Dec 6, 2022
@arbrandes
Copy link
Contributor

During Olive cutting earlier today:

  • Steps 4 and 5 were skipped, as it doesn't make sense to test the Native Installation anymore. And while we could use Tutor to do it, it was decided that because of the recent addition of the Community Test Plan and the corresponding tests, and because the Tutor images were rebuilt only a few hours later, we could skip the tests.

  • We no longer need to drop the release manager permissions.

@arbrandes
Copy link
Contributor

We've done what we can for Olive (@kdmccormick made changes to the release instructions), but there are still some wrinkles. Now bumping this to Palm, by which time we may consider closing it.

@arbrandes arbrandes modified the milestones: Olive.1, Palm.1 Dec 12, 2022
@arbrandes arbrandes added the documentation Relates to documentation improvements label Dec 12, 2022
@kdmccormick
Copy link
Member Author

For each problem listed here, either:

In general, anecdotally, it seems like the release process has become more repeatable since Nutmeg. @mtyaka has been able to transition into the role and lead releases without any major problems (as far as I know!)

Going to close this as a success 🎉 BTR, feel free to open a new issue for Palm+ if it seems necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation improvements enhancement Relates to new features or improvements to existing features
Projects
Development

No branches or pull requests

5 participants