Skip to content

Commit e2e21e6

Browse files
authored
Merge pull request #238 from edx-solutions/djoy/TNL-7184_less_publish_events
fix: Properly limit 'feedback.opened' events
2 parents 1a82115 + f79b211 commit e2e21e6

File tree

3 files changed

+35
-4
lines changed

3 files changed

+35
-4
lines changed

Changelog.md

Lines changed: 33 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,37 @@
11
Drag and Drop XBlock changelog
22
==============================
33

4+
Version 2.2.10 (2020-04-14)
5+
---------------------------
6+
7+
* Fix bug where 'edx.drag_and_drop_v2.feedback.opened' event was sent to publish_event endpoint excessively on mouse move. (PR #238)
8+
9+
Version 2.2.9 (2020-04-03)
10+
--------------------------
11+
12+
* Updated fragment import to remove deprecation warning which was causing extra logs in Splunk etc.
13+
14+
Version 2.2.8 (2020-01-13)
15+
--------------------------
16+
17+
* Updated code to render custom zone title as HTML
18+
19+
Version 2.2.7 (????-??-??)
20+
-------------------
21+
22+
* NOTE: This version was skipped / is not documented.
23+
24+
Version 2.2.6 (2019-10-08)
25+
--------------------------
26+
27+
* Python3 compatible.
28+
29+
Version 2.2.5 (2019-10-04)
30+
--------------------------
31+
32+
* This repository is now python3 compatible.
33+
* Update the xblock-sdk hash which is python3 compatible also.
34+
435
Version 2.2.4 (2019-07-30)
536
---------------------------
637

@@ -56,7 +87,7 @@ Version 2.1.5 (2017-11-06)
5687
Version 2.1.4 (2017-11-06)
5788
---------------------------
5889

59-
* Make XBlock always emit `progress` event explicitly when it is marked as complete.
90+
* Make XBlock always emit `progress` event explicitly when it is marked as complete.
6091

6192
Version 2.1.3 (2017-10-05)
6293
---------------------------
@@ -92,7 +123,7 @@ Version 2.0.12 (2016-11-08)
92123
* [SOL-2094][sol-2094] Fixed problem preventing DnDv2 blocks from being scored or graded.
93124
* Highest grade achieved is now displayed in feedback area
94125
* Renamed "Maximum score" field to "Problem Weight" to be in line with CAPA problems and avoid confusion.
95-
126+
96127
[sol-2030]: https://openedx.atlassian.net/browse/SOL-2030
97128
[sol-2094]: https://openedx.atlassian.net/browse/SOL-2094
98129

drag_and_drop_v2/public/js/drag_and_drop.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1139,7 +1139,7 @@ function DragAndDropBlock(runtime, element, configuration) {
11391139
delete state.closing;
11401140
}
11411141
// Has feedback been set?
1142-
if (state.feedback) {
1142+
if (state.feedback && state.feedback.length > 0) {
11431143
var data = {
11441144
event_type: 'edx.drag_and_drop_v2.feedback.opened',
11451145
content: concatenateFeedback(state.feedback),

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def package_data(pkg, root_list):
2323

2424
setup(
2525
name='xblock-drag-and-drop-v2',
26-
version='2.2.9',
26+
version='2.2.10',
2727
description='XBlock - Drag-and-Drop v2',
2828
packages=['drag_and_drop_v2'],
2929
install_requires=[

0 commit comments

Comments
 (0)