Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the README mentioning that the cache should be disabled? #4

Open
pfrenssen opened this issue Nov 19, 2018 · 1 comment · May be fixed by #36
Open

Why is the README mentioning that the cache should be disabled? #4

pfrenssen opened this issue Nov 19, 2018 · 1 comment · May be fixed by #36

Comments

@pfrenssen
Copy link
Member

The README contains an entire section about how to disable the page cache but it doesn't explain why this is needed.

Does this mean that the module is not compatible with having the page cache enabled? This cache is very important for websites that do not have a dedicated reverse proxy like Varnish.

Can we clarify what is needed to make the module compatible with page caching? It is usually not very difficult to correctly support caching, D8 offers cache tags and cache contexts for this purpose.
@brummbar
Copy link
Contributor

You are correct @pfrenssen , I didn't realise that part was in the README. It's misleading, this module doesn't require caching to be disabled.

pfrenssen added a commit to pfrenssen/media_avportal that referenced this issue Nov 4, 2019
@pfrenssen
Remove the section about disabling the page cache.
c315946 
Fixes openeuropa#4
@pfrenssen pfrenssen linked a pull request Nov 4, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the section about disabling the page cache. pfrenssen/media_avportal
2 participants
@pfrenssen @brummbar