From 0dd6a1a23f9a2afbaf2c93e6730c05ef5f1a37e5 Mon Sep 17 00:00:00 2001 From: tobhe Date: Sat, 2 Sep 2023 18:16:02 +0000 Subject: [PATCH] Remove unneccessary id == NULL check after dereferencing it. id can never be NULL here. Found by tb@ --- iked/ca.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/iked/ca.c b/iked/ca.c index 9ac70715..435c360f 100644 --- a/iked/ca.c +++ b/iked/ca.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ca.c,v 1.96 2023/08/04 19:06:25 claudio Exp $ */ +/* $OpenBSD: ca.c,v 1.97 2023/09/02 18:16:02 tobhe Exp $ */ /* * Copyright (c) 2020-2021 Tobias Heider @@ -227,8 +227,7 @@ ca_certbundle_add(struct ibuf *buf, struct iked_id *id) size_t len = ibuf_size(id->id_buf); void *val = ibuf_data(id->id_buf); - if (id == NULL || - buf == NULL || + if (buf == NULL || ibuf_add(buf, &type, sizeof(type)) != 0 || ibuf_add(buf, &len, sizeof(len)) != 0 || ibuf_add(buf, val, len) != 0)