Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 24, 2025

Hi all,

This pull request contains a backport of commit e18e95ed from the openjdk/jdk repository.

Clean backport to make test more robustness, change has been verified locally on linux-x64. Test-fix only, no risk.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346962 needs maintainer approval

Issue

  • JDK-8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4194/head:pull/4194
$ git checkout pull/4194

Update a local copy of the PR:
$ git checkout pull/4194
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4194

View PR using the GUI difftool:
$ git pr show -t 4194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4194.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e18e95ed11c1df7eeb162c2303f027564ed6f6aa 8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@sendaoYan This pull request has not yet been marked as ready for integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant