Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: small_gicp: Efficient and parallel algorithms for point cloud registration #6900

Closed
editorialbot opened this issue Jun 18, 2024 · 39 comments
Assignees
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 18, 2024

Submitting author: @koide3 (Kenji Koide)
Repository: https://github.com/koide3/small_gicp
Branch with paper.md (empty if default branch): paper
Version: v0.1.0
Editor: @diehlpk
Reviewers: @versatran01, @abougouffa
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc"><img src="https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc/status.svg)](https://joss.theoj.org/papers/059b017c823ed9fd211fc91373cdc2cc)

Author instructions

Thanks for submitting your paper to JOSS @koide3. Currently, there isn't a JOSS editor assigned to your paper.

@koide3 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Jun 18, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1109/icra.2011.5980567 may be a valid DOI for title: 3D is here: Point Cloud Library (PCL)
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- 10.1109/lra.2022.3152830 may be a valid DOI for title: Faster-LIO: Lightweight Tightly Coupled Lidar-Iner...
- 10.1109/icra48506.2021.9560835 may be a valid DOI for title: Voxelized GICP for Fast and Accurate 3D Point Clou...
- 10.1007/bf01427149 may be a valid DOI for title: Iterative point matching for registration of free-...
- 10.15607/rss.2009.v.021 may be a valid DOI for title: Generalized-icp.

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (2413.3 files/s, 229951.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             40            798            276           3548
C/C++ Header                    45            781            734           2872
Markdown                         8            235              0            668
Python                           9            248             79            643
YAML                            10             64             13            449
CMake                            3             46             43            288
Bourne Shell                     4             14              0             55
TeX                              1              5              0             50
Dockerfile                       2             22              0             42
TOML                             1              9              0             40
make                             1              5              0             23
XML                              1              4              3             15
reStructuredText                 2              8             12              9
-------------------------------------------------------------------------------
SUM:                           127           2239           1160           8702
-------------------------------------------------------------------------------

Commit count by author:

    65	k.koide
    46	koide3
     4	Martin Valgur
     2	Atticus Zhou
     2	Daisuke Nishimatsu
     2	Nikhil Khedekar

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 663

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @koide3 - thanks for your submission.

Please

  1. Work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. After you make changes to your .bib file, then use the command @editorialbot check references to check them again
  2. Fix the formatting of your references - follow the example paper. Use the command @editorialbot generate pdf after making changes (or when the references are right) to make a new PDF

@editorialbot commands need to be the first entry in a new comment.

In the meantime, I'll look for an editor for your submission.

@danielskatz
Copy link

👋 @galessiorob - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @galessiorob as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@koide3
Copy link

koide3 commented Jun 19, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@koide3
Copy link

koide3 commented Jun 19, 2024

👋 @danielskatz
Thank you for handling our submission. I just updated and re-generated the paper accordingly. I look forward to receiving reviews.

@danielskatz
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ICRA.2011.5980567 is OK
- 10.48550/arXiv.1801.09847 is OK
- 10.1109/LRA.2022.3152830 is OK
- 10.1109/ICRA48506.2021.9560835 is OK
- 10.1007/BF01427149 is OK
- 10.15607/rss.2009.v.021 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

@koide3 - thanks for the updates. Once there is an editor, they will be in touch with you about next steps

@danielskatz
Copy link

👋 @diehlpk - Do you think you would be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Jun 19, 2024

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@koide3
Copy link

koide3 commented Jun 20, 2024

@danielskatz
Thank you so much for serving as an editor of our submission. As reviewer candidates, I found the following people from the reviewer list: SteveMacenski, abougouffa, versatran01, jingnanshi, CameronDevine, ekorudiawan

@danielskatz
Copy link

@diehlpk is the editor. I am the track editor, and you won't hear from me again until the end of the process or if there are problems along the way

@koide3
Copy link

koide3 commented Jun 20, 2024

Sorry, I mistyped. Thank you @diehlpk for serving as an editor.

@diehlpk
Copy link
Member

diehlpk commented Jun 24, 2024

Hi @koide3 could you please recommend some potential reviewers. Please post their GitHub handle without the @ so they are not getting a notification yet.

@koide3
Copy link

koide3 commented Jun 25, 2024

@diehlpk
As reviewer candidates, I found the following people from the reviewer list: SteveMacenski, abougouffa, versatran01, jingnanshi, CameronDevine, ekorudiawan

@diehlpk
Copy link
Member

diehlpk commented Jun 28, 2024

Hi @SteveMacenski do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jun 28, 2024

Hi @abougouffa do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Jun 28, 2024

Hi @versatran01 do you have time to review this paper?

@SteveMacenski
Copy link

I can do it

@abougouffa
Copy link

Hi @abougouffa do you have time to review this paper?

Hello @diehlpk, yes I can! Thanks for the mention.

@versatran01
Copy link

@diehlpk Yes I can review this paper.

@diehlpk
Copy link
Member

diehlpk commented Jul 1, 2024

@editorialbot add @versatran01 as reviewer

@editorialbot
Copy link
Collaborator Author

@versatran01 added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jul 1, 2024

@editorialbot add @abougouffa as reviewer

@editorialbot
Copy link
Collaborator Author

@abougouffa added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Jul 1, 2024

Hi @versatran01 and @abougouffa thanks for agreeing to review.

@diehlpk
Copy link
Member

diehlpk commented Jul 1, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants