Skip to content

Validation of project location types #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fretchen opened this issue Jul 1, 2024 · 3 comments
Open

Validation of project location types #72

fretchen opened this issue Jul 1, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@fretchen
Copy link
Collaborator

fretchen commented Jul 1, 2024

The location types are found in the worksheet Location Types IATI and New. From what I understand they are loosely based on the IATI location types, which can be found here. Those types have four attributes:

  • Code
  • Name
  • Description
  • Category

I suggest to start comparing the location types here with the ones from the IATI standard and move them towards a json / csv. This would allow

a) versioning
b) simpler validation
c) simpler comparision with the IATI standards

From what I understand our location types also have four attributes:

  • KC-Theme / Subsector
  • physical or immaterial location type
  • (IATI) Location Type Name (EN)
  • Geodata type

So to get started on this I have a few questions.

Questions

  1. Is it correct that our location types and the IATI location type should same names ?
  2. Is there a way to also use location codes for our location types ? This would allow us to identify IATI types for which we changed the name.
  3. I would strongly suggest to use single words to describe each attribute of our types. They could be Subsector / Immateriality / Name / Type.
  4. Is it correct that we ignore category, code and description within the IATI location types for the moment ?

Solving this seems like a prerequisite for the work on #70 from what I can see.

@Maja4Dev I think that you know the answers to these questions best.

@fretchen fretchen added the enhancement New feature or request label Jul 1, 2024
@Maja4Dev
Copy link
Collaborator

Maja4Dev commented Jul 3, 2024

I would leave out KC-Theme / Subsector, since this only helps with finding the location types, but are not directly connected in one-to-one relationship to each other.

The (IATI) Location Type Name (EN) is actually

  • Name

For the others I propose:

  • character (phys vs imm)
  • geometric (point, line, polygon)

What do you think?

@Maja4Dev
Copy link
Collaborator

Maja4Dev commented Jul 3, 2024

By the way, I am planning to add the other language versions FR, SP, PT, DE as well as adding the IATI Categories of the new location types (in the Excel template this is the hidden column H) and the descriptons of the new location types. You can add these then once this is ready.

@fretchen fretchen self-assigned this Jul 3, 2024
@fretchen
Copy link
Collaborator Author

fretchen commented Jul 3, 2024

Ok. The way I understand it and will implement it (or try to see if github copilot might be able to do it):

  • Pull all the location types from the worksheet Location Types IATI and New of the xlsx template.
  • Ignore the line Subsector for the moment.
  • Use the hidden column code as code.
  • Move this all into a json where each item has four attributes (code, name, character, geometry).

Lets see how far co-pilot could work this through....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants