Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the template example rows consistent with the technical notes #77

Closed
fretchen opened this issue Jul 19, 2024 · 1 comment · Fixed by #79
Closed

Make the template example rows consistent with the technical notes #77

fretchen opened this issue Jul 19, 2024 · 1 comment · Fixed by #79
Labels
bug Something isn't working

Comments

@fretchen
Copy link
Collaborator

fretchen commented Jul 19, 2024

In the template we have a number of rows with examples. My understanding is that they should be in agreement with the technical guidelines. Otherwise they might confuse the user and also fail in automatic validation tests...

This really starts to become obvious as we start work on automatic validators as for example in #76. There the validator currently fails on numerous rows with data. The current errors are:

Row 3 is valid
Row:  4
Error in row: 4
'approximate (admin unit)' is not one of ['exact', 'approximate']
Row:  5
Error in row: 5
'longitude' is a required property
Row:  6
Error in row: 6
'kfwProjectNoINPRO' is a required property
Row:  7
Error in row: 7
'kfwProjectNoINPRO' is a required property
Row:  8
Error in row: 8
'kfwProjectNoINPRO' is a required property
Row:  9
Error in row: 9
'kfwProjectNoINPRO' is a required property
Row:  10
Error in row: 10
'kfwProjectNoINPRO' is a required property
Row:  11
Error in row: 11
'kfwProjectNoINPRO' is a required property
Row:  12
Error in row: 12
'kfwProjectNoINPRO' is a required property
Row:  13
Error in row: 13
'kfwProjectNoINPRO' is a required property
Row:  14
Error in row: 14
'kfwProjectNoINPRO' is a required property
Row:  15
Error in row: 15
'kfwProjectNoINPRO' is a required property
Row:  16
Error in row: 16
'kfwProjectNoINPRO' is a required property
Row:  17
Error in row: 17
'kfwProjectNoINPRO' is a required property
Row:  18
Error in row: 18
'kfwProjectNoINPRO' is a required property

From what I can see all these complaints are valid. I would think that each entered line in the example template should be valid, but maybe three data lines are also sufficient ? @Maja4Dev I think that this one is most likely close to you no ?

@fretchen fretchen added the bug Something isn't working label Jul 19, 2024
@fretchen
Copy link
Collaborator Author

Fixed by #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant