Partition and Selector cannot be used together

AiRanthem · AiRanthem · commit 1b22e564c274 · 2024-12-17T19:16:28.000+08:00
Signed-off-by: AiRanthem &lt;zhongtianyun.zty@alibaba-inc.com&gt;
diff --git a/pkg/webhook/sidecarset/validating/sidecarset_create_update_handler.go b/pkg/webhook/sidecarset/validating/sidecarset_create_update_handler.go
@@ -209,7 +209,9 @@ func (h *SidecarSetCreateUpdateHandler) validateSidecarSetInjectionStrategy(obj
 			errList = append(errList, field.Invalid(field.NewPath("revision").Child("policy"), revisionInfo, fmt.Sprintf("Invalid policy %v, supported: [%s, %s]",
 				revisionInfo.Policy, appsv1alpha1.AlwaysSidecarSetInjectRevisionPolicy, appsv1alpha1.PartialSidecarSetInjectRevisionPolicy)))
 		}
-
+		if obj.Spec.UpdateStrategy.Partition != nil && obj.Spec.UpdateStrategy.Selector != nil {
+			errList = append(errList, field.Invalid(field.NewPath("updateStrategy"), obj.Spec.UpdateStrategy, "Partition and Selector cannot be used together"))
+		}
 	}
 	return errList
 }

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,9 @@ func (h *SidecarSetCreateUpdateHandler) validateSidecarSetInjectionStrategy(obj`
`209`	`209`	`errList = append(errList, field.Invalid(field.NewPath("revision").Child("policy"), revisionInfo, fmt.Sprintf("Invalid policy %v, supported: [%s, %s]",`
`210`	`210`	`revisionInfo.Policy, appsv1alpha1.AlwaysSidecarSetInjectRevisionPolicy, appsv1alpha1.PartialSidecarSetInjectRevisionPolicy)))`
`211`	`211`	`}`
`212`		`-`
	`212`	`+ if obj.Spec.UpdateStrategy.Partition != nil && obj.Spec.UpdateStrategy.Selector != nil {`
	`213`	`+ errList = append(errList, field.Invalid(field.NewPath("updateStrategy"), obj.Spec.UpdateStrategy, "Partition and Selector cannot be used together"))`
	`214`	`+ }`
`213`	`215`	`}`
`214`	`216`	`return errList`
`215`	`217`	`}`