Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Additional checks messages #105

Open
kd-ods opened this issue Oct 23, 2024 · 1 comment
Open

Edit Additional checks messages #105

kd-ods opened this issue Oct 23, 2024 · 1 comment
Assignees

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Oct 23, 2024

Currently this is how the validation errors look:

Image

The additional checks are much more muted and do not share the same message style and formatting:

Image

We should bring the content and style of the additional checks into line with the validation errors.

@kd-ods kd-ods self-assigned this Oct 23, 2024
@kd-ods
Copy link
Collaborator Author

kd-ods commented Oct 23, 2024

It looks like there are around 75 addition check messages in https://github.com/openownership/cove-bods/blob/addbods04/cove_bods/templates/cove_bods/additional_checks_table.html.

I've agreed with @radix0000 that I'll edit the messages in the template on a branch which radix0000 will create. (The branch will be deployed and usable so that I can check that I don't break the template with any edits.)

@radix0000 - Here is the edit for the first message in the template:

From:

                <td>
                    {% trans 'The statement has an identifier scheme which is not valid.'  %}
                </td>
                <td>
                    {% trans 'Invalid Scheme' %}: {{ additional_check.scheme }}
                </td>
                <td>
                    {{ additional_check.entity_statement }}
                </td>
          

To:

                <td>
                    {% blocktrans %}<code>scheme</code> is not valid. Check the BODS documentation for guidance on identifiers. {%endblocktrans%}
                </td>
                <td>
                    <code>scheme</code>: {{ additional_check.scheme }}
                </td>
                <td>
                    {{ additional_check.entity_statement }}
                </td>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant