Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to customize deletion order for shortcut testing #58

Open
EeethB opened this issue Aug 17, 2023 · 0 comments
Open

Add a function to customize deletion order for shortcut testing #58

EeethB opened this issue Aug 17, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@EeethB
Copy link
Contributor

EeethB commented Aug 17, 2023

Simply deleting hypotheses in a custom order is not difficult. The main hurdle is figuring out valid deletion orders. First, all rejected hypotheses must come before non-rejected, which is easy once you have initial test results. But the rejected ones cannot necessarily go in any order, as deleting one hypothesis increases weights of other hypotheses. The simplest route from a coding perspective would probably be to just loop over every permutation of rejected hypotheses and mark them as valid or not. But this would get slow very quickly. I think there's some way to do it using tricks with the closure. Like checking each row of the closure to see if there's a path to it using its parent rows. I guess parents of each row could be calculated on the fly by replacing each 0 with a 1, that might not be so slow. But there should be a formula method similar to what's used in graph_generate_weights().

@EeethB EeethB self-assigned this Aug 17, 2023
@EeethB EeethB added the enhancement New feature or request label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant