Methods are not ambiguous if their argument size differs

timtebeek · timtebeek · commit 9fa19587f081 · 2025-01-11T16:04:45.000+01:00
Fixes #427
diff --git a/src/main/java/org/openrewrite/staticanalysis/UseLambdaForFunctionalInterface.java b/src/main/java/org/openrewrite/staticanalysis/UseLambdaForFunctionalInterface.java
@@ -210,7 +210,7 @@ private boolean methodArgumentRequiresCast(J.Lambda lambda, MethodCall method, i
             }
 
             private boolean areMethodsAmbiguous(JavaType.@Nullable Method m1, JavaType.@Nullable Method m2) {
-                if (m1 == null || m2 == null) {
+                if (m1 == null || m2 == null || m1.getParameterTypes().size() != m2.getParameterTypes().size()) {
                     return false;
                 }
                 if (m1 == m2) {

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ private boolean methodArgumentRequiresCast(J.Lambda lambda, MethodCall method, i`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`private boolean areMethodsAmbiguous(JavaType.@Nullable Method m1, JavaType.@Nullable Method m2) {`
`213`		`- if (m1 == null \|\| m2 == null) {`
	`213`	`+ if (m1 == null \|\| m2 == null \|\| m1.getParameterTypes().size() != m2.getParameterTypes().size()) {`
`214`	`214`	`return false;`
`215`	`215`	`}`
`216`	`216`	`if (m1 == m2) {`