Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onehot of SPR acknowledgments fail #137

Open
Harshitha172000 opened this issue Aug 6, 2021 · 2 comments
Open

onehot of SPR acknowledgments fail #137

Harshitha172000 opened this issue Aug 6, 2021 · 2 comments

Comments

@Harshitha172000
Copy link
Member

Harshitha172000 commented Aug 6, 2021

Property: No two spr groups can acknowledge at the same time.

Assertion:

https://github.com/openrisc/mor1kx/blob/master/bench/formal/fspr_master.v#L66#L70

always @(posedge clk)
      if (f_past_valid)
         assert ($onehot0({spr_bus_ack_dc_i, spr_bus_ack_ic_i,
                 spr_bus_ack_dmmu_i, spr_bus_ack_immu_i}));

Back-to-back spr requests may delay the fall of spr acknowledgment. Meanwhile, a new spr request would have been acknowledged. Here, we can see spr_bus_ack_ic_i and spr_bus_ack_dc_i signals are high at the same time.

Trace:

image

@stffrdhrn
Copy link
Member

can you put a link to the code, or mention the module where this is happening?

@Harshitha172000
Copy link
Member Author

It's tested in the spr master interface, referring to mor1kx_cpu_cappuccino.v module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants