Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement mechanism to fail stale search replicas #17032

Open
vinaykpud opened this issue Jan 15, 2025 · 2 comments
Open

[Feature Request] Implement mechanism to fail stale search replicas #17032

vinaykpud opened this issue Jan 15, 2025 · 2 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep Indexing Indexing, Bulk Indexing and anything related to indexing Search:Performance

Comments

@vinaykpud
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, there is no mechanism in place to automatically fail search replicas that are significantly lagging behind the primary shard and have become stale. This can lead to inconsistent search results by returning stale data.

Describe the solution you'd like

With Issue #16801, we are proposing to redefine the computation of lag. The lag will now be defined as the difference between the current time and the timestamp of the latest received checkpoint (cp). This change means we will no longer compare the lag with the primary shard directly. Instead, we need a mechanism to monitor the lag in search replica shards. If a search replica exceeds a predefined lag threshold, it should be marked as stale and automatically fail.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@vinaykpud vinaykpud added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 15, 2025
@sandeshkr419 sandeshkr419 added Indexing Indexing, Bulk Indexing and anything related to indexing untriaged Indexing:Replication Issues and PRs related to core replication framework eg segrep and removed untriaged labels Jan 22, 2025
@sandeshkr419
Copy link
Contributor

[Search Triage] - I think this might better fit in with index/segment replication side. Adding those tags and keeping untriaged label.

@vinaykpud
Copy link
Contributor Author

This is related to Meta issue : #15306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep Indexing Indexing, Bulk Indexing and anything related to indexing Search:Performance
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants