Prevent unnecessary heap sort when buckets needs to be ordered by key… #17252
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msfroh Please let me know if this change looks legit to you, thank you |
|
❌ Gradle check result for b007591: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
… in NumericTermsAggregation Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
rishabhmaurya
force-pushed
the
num-agg-opt
branch
from
b007591 to
6141759
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17252 +/- ##
============================================
- Coverage 72.43% 72.29% -0.14%
+ Complexity 65725 65710 -15
============================================
Files 5318 5318
Lines 305675 305680 +5
Branches 44350 44352 +2
============================================
- Hits 221408 220999 -409
- Misses 66055 66597 +542
+ Partials 18212 18084 -128 ☔ View full report in Codecov by Sentry. |
msfroh
approved these changes
Feb 5, 2025
rishabhmaurya
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
rishabhmaurya
added
backport
|
@msfroh looks like you already approved, if you do not have any concerns, we can merge it. |
jainankitk
approved these changes
Feb 6, 2025
rishabhmaurya
added a commit
to rishabhmaurya/OpenSearch
that referenced
this pull request
Feb 11, 2025
… in NumericTermsAggregation (opensearch-project#17252) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 3f793b6)
msfroh
pushed a commit
that referenced
this pull request
Feb 11, 2025
… in NumericTermsAggregation (#17252) (#17290) (cherry picked from commit 3f793b6) Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankit Jain <akjain@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can slightly improve performance of Numeric term Aggs by avoiding double sorting - first by count and then by key before final reduce
Description
We don't need to sort the buckets by
_count. PriorityQueue will ensure topN buckets by_count, as final reduce order is always by key in NumericTermsAggregation andResultStrategy#buildResult()is anyways sorting the buckets by key before final reduce, thus sorting the buckets by count or whatever the order clause was, is redundant.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.